Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14411403
D10057.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D10057.diff
View Options
diff --git a/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php b/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
--- a/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
+++ b/src/applications/repository/search/PhabricatorRepositoryCommitSearchIndexer.php
@@ -66,27 +66,10 @@
PhabricatorRepositoryRepositoryPHIDType::TYPECONST,
$date_created);
- $comments = PhabricatorAuditComment::loadComments(
- $this->getViewer(),
- $commit->getPHID());
- foreach ($comments as $comment) {
- if (strlen($comment->getContent())) {
- $doc->addField(
- PhabricatorSearchField::FIELD_COMMENT,
- $comment->getContent());
- }
- }
-
- $inlines = PhabricatorAuditInlineComment::loadPublishedComments(
- $this->getViewer(),
- $commit->getPHID());
- foreach ($inlines as $inline) {
- if (strlen($inline->getContent())) {
- $doc->addField(
- PhabricatorSearchField::FIELD_COMMENT,
- $inline->getContent());
- }
- }
+ $this->indexTransactions(
+ $doc,
+ new PhabricatorAuditTransactionQuery(),
+ array($commit->getPHID()));
return $doc;
}
diff --git a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
--- a/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
+++ b/src/applications/search/index/PhabricatorSearchDocumentIndexer.php
@@ -101,7 +101,6 @@
$xactions = id(clone $query)
->setViewer($this->getViewer())
->withObjectPHIDs($phids)
- ->withTransactionTypes(array(PhabricatorTransactions::TYPE_COMMENT))
->execute();
foreach ($xactions as $xaction) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Dec 25, 10:13 AM (9 h, 17 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6925027
Default Alt Text
D10057.diff (1 KB)
Attached To
Mode
D10057: Use ApplicationTransactions when indexing commit/audit comments
Attached
Detach File
Event Timeline
Log In to Comment