D9299.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D9299.diff
View Options

	diff --git a/src/applications/passphrase/controller/PassphraseCredentialEditController.php b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
	--- a/src/applications/passphrase/controller/PassphraseCredentialEditController.php
	+++ b/src/applications/passphrase/controller/PassphraseCredentialEditController.php
	@@ -26,23 +26,18 @@
	return new Aphront404Response();
	}

	- $type = PassphraseCredentialType::getTypeByConstant(
	- $credential->getCredentialType());
	- if (!$type) {
	- throw new Exception(pht('Credential has invalid type "%s"!', $type));
	- }
	-
	- if (!$type->isCreateable()) {
	- throw new Exception(
	- pht('Credential has noncreateable type "%s"!', $type));
	- }
	+ $type = $this->getCredentialType($credential->getCredentialType());

	$is_new = false;
	} else {
	$type_const = $request->getStr('type');
	- $type = PassphraseCredentialType::getTypeByConstant($type_const);
	- if (!$type) {
	- return new Aphront404Response();
	+ $type = $this->getCredentialType($type_const);
	+
	+ if (!$type->isCreateable()) {
	+ throw new Exception(
	+ pht(
	+ 'Credential has noncreateable type "%s"!',
	+ $credential->getCredentialType()));
	}

	$credential = PassphraseCredential::initializeNewCredential($viewer)
	@@ -358,4 +353,15 @@
	));
	}

	+ private function getCredentialType($type_const) {
	+ $type = PassphraseCredentialType::getTypeByConstant($type_const);
	+
	+ if (!$type) {
	+ throw new Exception(
	+ pht('Credential has invalid type "%s"!', $type_const));
	+ }
	+
	+ return $type;
	+ }
	+
	}