Fixes T4991. Two issues:
- These error messages pass an object to "%s", when they mean to pass a type constant.
- The check for noncreatable credentials is incorrectly in the "edit" branch of the controller.
Details
Details
- Reviewers
joshuaspence btrahan - Maniphest Tasks
- T4991: Object of class PassphraseCredentialTypeSSHPrivateKeyFile could not be converted to string
- Commits
- Restricted Diffusion Commit
rPb93c2f68521d: Fix two Passphrase credential type issues
- Edited a "SSH Key on disk" credential.
- Tried to create a credential with a bogus type.
Diff Detail
Diff Detail
- Repository
- rP Phabricator
- Lint
Lint Skipped - Unit
Tests Skipped