D13430.id32517.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D13430.id32517.diff
View Options

	diff --git a/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php b/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php
	--- a/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php
	+++ b/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php
	@@ -3,33 +3,27 @@
	final class PhabricatorSubscriptionsListController
	extends PhabricatorController {

	- private $phid;
	-
	- public function willProcessRequest(array $data) {
	- $this->phid = idx($data, 'phid');
	- }
	-
	public function shouldAllowPublic() {
	return true;
	}

	- public function processRequest() {
	- $request = $this->getRequest();
	-
	+ public function handleRequest(AphrontRequest $request) {
	$viewer = $request->getUser();
	- $phid = $this->phid;
	-
	$object = id(new PhabricatorObjectQuery())
	->setViewer($viewer)
	- ->withPHIDs(array($phid))
	+ ->withPHIDs(array($request->getURIData('phid')))
	->executeOne();
	+ if (!$object) {
	+ return new Aphront404Response();
	+ }

	- if ($object instanceof PhabricatorSubscribableInterface) {
	- $subscriber_phids = PhabricatorSubscribersQuery::loadSubscribersForPHID(
	- $phid);
	+ if (!$object instanceof PhabricatorSubscribableInterface) {
	+ return new Aphront404Response();
	}

	- $handle_phids = $subscriber_phids;
	+ $phid = $object->getPHID();
	+
	+ $handle_phids = PhabricatorSubscribersQuery::loadSubscribersForPHID($phid);
	$handle_phids[] = $phid;

	$handles = id(new PhabricatorHandleQuery())