Page MenuHomePhabricator

Fix a possible undefined variable
ClosedPublic

Authored by epriestley on Jun 25 2015, 12:51 PM.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 6:34 AM
Unknown Object (File)
Fri, May 3, 4:03 AM
Unknown Object (File)
Mon, Apr 29, 9:03 PM
Unknown Object (File)
Thu, Apr 25, 12:01 AM
Unknown Object (File)
Sat, Apr 20, 12:26 AM
Unknown Object (File)
Fri, Apr 19, 8:08 PM
Unknown Object (File)
Wed, Apr 17, 9:14 PM
Unknown Object (File)
Fri, Apr 12, 9:57 PM
Subscribers

Details

Reviewers
btrahan
Commits
Restricted Diffusion Commit
rP8b9428b6dac2: Fix a possible undefined variable
Summary

I pulled this out of the logs; not sure how anyone hit it, but this controller could bump into an undefined variable here:

2015/06/24 22:59:55 [error] 10150#0: *172493 FastCGI sent in stderr: "PHP message: [2015-06-24 22:59:55] EXCEPTION: (RuntimeException) Undefined variable: subscriber_phids at [<phutil>/src/error/PhutilErrorHandler.php:210]
PHP message: arcanist(head=master, ref.master=b697a3b80bdc), phabricator(head=redesign-2015, ref.master=0fd0f171f10f, ref.redesign-2015=1a5f986d73dd), phutil(head=master, ref.master=74c9cb3a266e)
PHP message:   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer, array) called at [<phabricator>/src/applications/subscriptions/controller/PhabricatorSubscriptionsListController.php:32]
PHP message:   #1 <#2> PhabricatorSubscriptionsListController::processRequest() called at [<phabricator>/src/aphront/AphrontController.php:33]
PHP message:   #2 <#2> AphrontController::handleRequest(AphrontRequest) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:226]
PHP message:   #3 phlog(RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontDefaultApplicationConfiguration.php:229]
PHP message:   #4 AphrontDefaultApplicationConfiguration::handleException(RuntimeException) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:230]
PHP message:   #5 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phabricator>/src/aphront/configuration/AphrontApplicationConfiguration.php:140]
PHP message:   #6 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phabricator>/webroot/index.php:21]" while reading response header from upstream, client: 167.114.156.198, server: , request: "GET /subscriptions/list/phid-wiki-366842d394398204f305/ HTTP/1.1", upstream: "fastcgi://unix:/core/var/pool/fpm.sock:", host: "secure.phabricator.com"

Clean things up a bit.

Test Plan

Clicked "6 others" subscriber link on a task with a bunch of subscribers.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley retitled this revision from to Fix a possible undefined variable.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Jun 25 2015, 5:00 PM
This revision was automatically updated to reflect the committed changes.