Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14388497
D3673.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
841 B
Referenced Files
None
Subscribers
None
D3673.diff
View Options
Index: src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
===================================================================
--- src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
+++ src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
@@ -61,7 +61,10 @@
}
public function validateField() {
- if (in_array($this->getUser()->getPHID(), $this->reviewers)) {
+ $allow_self_accept = PhabricatorEnv::getEnvConfig(
+ 'differential.allow-self-accept', false);
+ if (!$allow_self_accept
+ && in_array($this->getUser()->getPHID(), $this->reviewers)) {
$this->error = 'Invalid';
throw new DifferentialFieldValidationException(
"You may not review your own revision!");
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 22, 4:50 PM (1 h, 8 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6919044
Default Alt Text
D3673.diff (841 B)
Attached To
Mode
D3673: Allow to push revisions to review by himself to Differential (bug T1879, change 1/2, Differential part)
Attached
Detach File
Event Timeline
Log In to Comment