Page MenuHomePhabricator

D3673.diff
No OneTemporary

D3673.diff

Index: src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
===================================================================
--- src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
+++ src/applications/differential/field/specification/DifferentialReviewersFieldSpecification.php
@@ -61,7 +61,10 @@
}
public function validateField() {
- if (in_array($this->getUser()->getPHID(), $this->reviewers)) {
+ $allow_self_accept = PhabricatorEnv::getEnvConfig(
+ 'differential.allow-self-accept', false);
+ if (!$allow_self_accept
+ && in_array($this->getUser()->getPHID(), $this->reviewers)) {
$this->error = 'Invalid';
throw new DifferentialFieldValidationException(
"You may not review your own revision!");

File Metadata

Mime Type
text/plain
Expires
Sun, Dec 22, 4:50 PM (1 h, 8 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6919044
Default Alt Text
D3673.diff (841 B)

Event Timeline