D10393.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D10393.diff
View Options

	diff --git a/src/applications/herald/adapter/HeraldCommitAdapter.php b/src/applications/herald/adapter/HeraldCommitAdapter.php
	--- a/src/applications/herald/adapter/HeraldCommitAdapter.php
	+++ b/src/applications/herald/adapter/HeraldCommitAdapter.php
	@@ -443,7 +443,10 @@
	return null;
	}

	- switch ($revision->getStatus()) {
	+ $status = $data->getCommitDetail(
	+ 'precommitRevisionStatus',
	+ $revision->getStatus());
	+ switch ($status) {
	case ArcanistDifferentialRevisionStatus::ACCEPTED:
	case ArcanistDifferentialRevisionStatus::CLOSED:
	return $revision->getPHID();
	diff --git a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
	--- a/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
	+++ b/src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
	@@ -110,6 +110,11 @@
	$revision = $revision_query->executeOne();

	if ($revision) {
	+ if (!$data->getCommitDetail('precommitRevisionStatus')) {
	+ $data->setCommitDetail(
	+ 'precommitRevisionStatus',
	+ $revision->getStatus());
	+ }
	$commit_drev = PhabricatorEdgeConfig::TYPE_COMMIT_HAS_DREV;
	id(new PhabricatorEdgeEditor())
	->addEdge($commit->getPHID(), $commit_drev, $revision->getPHID())