Diffusion / Herald - tweak "Accepted Differential Revision exists" Herald field
ClosedPublic
Actions

Authored by btrahan on Aug 29 2014, 11:48 PM.

Details

Reviewers

epriestley

Maniphest Tasks

T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless
T4574: xxxxxxx"><//'\'\

Commits

Restricted Diffusion Commit
rP2f4addc67113: Diffusion / Herald - tweak "Accepted Differential Revision exists" Herald field

Summary

make it use the value of the revision before any post-commit magic has occurred. Fixes T4754

Test Plan

made a herald rule that said "if revision exists, and revision accept does not exists, block push". tried to push a commit that had a revision that wasn't accepted and I was blocked.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

btrahan updated this revision to Diff 25013.Aug 29 2014, 11:48 PM

btrahan added tasks: T4574: xxxxxxx"><//'\'\, T4754: "Accepted Differential Revision exists" Herald field is fairly meaningless.

btrahan retitled this revision from to Diffusion / Herald - tweak "Accepted Differential Revision exists" Herald field.

btrahan updated this object.

btrahan edited the test plan for this revision. (Show Details)

btrahan added a reviewer: epriestley.

Herald added subscribers: Korvin, epriestley. · View Herald TranscriptAug 29 2014, 11:48 PM

Harbormaster completed remote builds in B2397: Diff 25013.Aug 29 2014, 11:48 PM

mbishopim3 added a subscriber: mbishopim3.Sep 3 2014, 2:02 PM

One inline.

src/applications/repository/worker/commitmessageparser/PhabricatorRepositoryCommitMessageParserWorker.php
113–115	We should only write this if it isn't set yet. Otherwise, reparsing a commit with `scripts/repository/reparse.php` will incorrectly overwrite it with "closed".