Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14357485
D15553.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D15553.diff
View Options
diff --git a/src/applications/badges/controller/PhabricatorBadgesViewController.php b/src/applications/badges/controller/PhabricatorBadgesViewController.php
--- a/src/applications/badges/controller/PhabricatorBadgesViewController.php
+++ b/src/applications/badges/controller/PhabricatorBadgesViewController.php
@@ -70,7 +70,7 @@
$timeline,
$add_comment,
))
- ->addPropertySection(pht('BADGE DETAILS'), $details);
+ ->addPropertySection(pht('DESCRIPTION'), $details);
return $this->newPage()
->setTitle($title)
@@ -86,26 +86,8 @@
$view = id(new PHUIPropertyListView())
->setUser($viewer);
- $quality_name = PhabricatorBadgesQuality::getQualityName(
- $badge->getQuality());
-
- $view->addProperty(
- pht('Quality'),
- $quality_name);
-
- $view->addProperty(
- pht('Icon'),
- id(new PhabricatorBadgesIconSet())
- ->getIconLabel($badge->getIcon()));
-
- $view->addProperty(
- pht('Flavor'),
- $badge->getFlavor());
-
$description = $badge->getDescription();
if (strlen($description)) {
- $view->addSectionHeader(
- pht('Description'), PHUIPropertyListView::ICON_SUMMARY);
$view->addTextContent(
new PHUIRemarkupView($viewer, $description));
}
diff --git a/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php b/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php
--- a/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php
+++ b/src/applications/badges/view/PhabricatorBadgesRecipientsListView.php
@@ -27,7 +27,8 @@
PhabricatorPolicyCapability::CAN_EDIT);
$list = id(new PHUIObjectItemListView())
- ->setNoDataString(pht('This badge does not have any recipients.'));
+ ->setNoDataString(pht('This badge does not have any recipients.'))
+ ->setFlush(true);
foreach ($handles as $handle) {
$remove_uri = '/badges/recipients/'.
@@ -51,7 +52,8 @@
}
$box = id(new PHUIObjectBoxView())
- ->setHeaderText(pht('Recipients'))
+ ->setHeaderText(pht('RECIPIENTS'))
+ ->setBackground(PHUIObjectBoxView::BLUE_PROPERTY)
->setObjectList($list);
return $box;
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Dec 21, 5:24 AM (18 h, 17 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6912853
Default Alt Text
D15553.diff (2 KB)
Attached To
Mode
D15553: Clean up BadgeView a little bit
Attached
Detach File
Event Timeline
Log In to Comment