Clean up BadgeView a little bit
ClosedPublic
Actions

Authored by chad on Mar 31 2016, 9:59 PM.

Tags

None

Referenced Files

	F18737330: D15553.diff
	Wed, Oct 1, 10:12 AM

	F18116671: D15553.id37503.diff
	Aug 13 2025, 7:35 AM

	F18110762: D15553.id37502.diff
	Aug 11 2025, 11:35 PM

	F18109648: D15553.id.diff
	Aug 11 2025, 2:46 PM

	F18104074: D15553.diff
	Aug 10 2025, 9:41 AM

	Unknown Object (File)
	Jul 3 2025, 8:02 AM

	Unknown Object (File)
	May 26 2025, 10:02 PM

	Unknown Object (File)
	May 26 2025, 1:18 PM

View All Files

Subscribers

Korvin

Details

Reviewers

epriestley

Commits

rP59ef3a31d357: Clean up BadgeView a little bit

Summary

Uses BLUE_PROPERTY on Recipients box, removes redundent properties since we render the badge itself already.

Test Plan

View a badge with and without a description.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad updated this revision to Diff 37502.Mar 31 2016, 9:59 PM

chad retitled this revision from to Clean up BadgeView a little bit.

chad updated this object.

chad edited the test plan for this revision. (Show Details)

chad added a reviewer: epriestley.

Herald added a subscriber: Korvin. · View Herald TranscriptMar 31 2016, 9:59 PM

epriestley accepted this revision.Mar 31 2016, 10:04 PM

epriestley edited edge metadata.

This revision is now accepted and ready to land.Mar 31 2016, 10:04 PM

Closed by commit rP59ef3a31d357: Clean up BadgeView a little bit (authored by chad, committed by chad). · Explain WhyMar 31 2016, 10:05 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

badges/

controller/

PhabricatorBadgesViewController.php

20 lines

view/

PhabricatorBadgesRecipientsListView.php

6 lines

Diff 37503

View Options

src/applications/badges/controller/PhabricatorBadgesViewController.php