Page MenuHomePhabricator
Files F14351721

D9042.diff
No OneTemporary
Actions

D9042.diff
View Options

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -3159,7 +3159,11 @@
'DiffusionPathValidateController' => 'DiffusionController',
'DiffusionPushEventViewController' => 'DiffusionPushLogController',
'DiffusionPushLogController' => 'DiffusionController',
- 'DiffusionPushLogListController' => 'DiffusionPushLogController',
+ 'DiffusionPushLogListController' =>
+ array(
+ 0 => 'DiffusionPushLogController',
+ 1 => 'PhabricatorApplicationSearchResultsControllerInterface',
+ ),
'DiffusionQuery' => 'PhabricatorQuery',
'DiffusionRawDiffQuery' => 'DiffusionQuery',
'DiffusionRepositoryController' => 'DiffusionController',
diff --git a/src/applications/differential/event/DifferentialActionMenuEventListener.php b/src/applications/differential/event/DifferentialActionMenuEventListener.php
--- a/src/applications/differential/event/DifferentialActionMenuEventListener.php
+++ b/src/applications/differential/event/DifferentialActionMenuEventListener.php
@@ -34,10 +34,9 @@
}
$person = $event->getValue('object');
- $href = '/differential/?authorPHIDs[]='.$person->getPHID();
+ $href = '/differential/?authors='.$person->getUsername();
return id(new PhabricatorActionView())
- ->setRenderAsForm(true)
->setIcon('differential-dark')
->setIconSheet(PHUIIconView::SPRITE_APPS)
->setName(pht('View Revisions'))
diff --git a/src/applications/home/controller/PhabricatorHomeMainController.php b/src/applications/home/controller/PhabricatorHomeMainController.php
--- a/src/applications/home/controller/PhabricatorHomeMainController.php
+++ b/src/applications/home/controller/PhabricatorHomeMainController.php
@@ -148,8 +148,8 @@
'Nothing appears to be critically broken right now.');
}
- $href = sprintf(
- '/maniphest/?statuses[]=%s&priorities[]=%s#R',
+ $href = urisprintf(
+ '/maniphest/?statuses=%s&priorities=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$unbreak_now);
$title = pht('Unbreak Now!');
@@ -196,8 +196,8 @@
}
$title = pht('Needs Triage');
- $href = sprintf(
- '/maniphest/?statuses[]=%s&priorities[]=%s&userProjects[]=%s#R',
+ $href = urisprintf(
+ '/maniphest/?statuses=%s&priorities=%s&userProjects=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$needs_triage,
$user->getPHID());
diff --git a/src/applications/maniphest/controller/ManiphestReportController.php b/src/applications/maniphest/controller/ManiphestReportController.php
--- a/src/applications/maniphest/controller/ManiphestReportController.php
+++ b/src/applications/maniphest/controller/ManiphestReportController.php
@@ -442,7 +442,7 @@
}
}
- $base_link = '/maniphest/?allProjects[]=';
+ $base_link = '/maniphest/?allProjects=';
$leftover_name = phutil_tag('em', array(), pht('(No Project)'));
$col_header = pht('Project');
$header = pht('Open Tasks by Project and Priority (%s)', $date);
diff --git a/src/applications/maniphest/event/ManiphestActionMenuEventListener.php b/src/applications/maniphest/event/ManiphestActionMenuEventListener.php
--- a/src/applications/maniphest/event/ManiphestActionMenuEventListener.php
+++ b/src/applications/maniphest/event/ManiphestActionMenuEventListener.php
@@ -44,29 +44,4 @@
->setHref($view_uri);
}
- private function renderProjectItems(PhutilEvent $event) {
- if (!$this->canUseApplication($event->getUser())) {
- return null;
- }
-
- $project = $event->getValue('object');
-
- $phid = $project->getPHID();
- $view_uri = '/maniphest/?statuses[]=0&allProjects[]='.$phid.'#R';
- $create_uri = '/maniphest/task/create/?projects='.$phid;
-
- return array(
- id(new PhabricatorActionView())
- ->setIcon('maniphest-dark')
- ->setIconSheet(PHUIIconView::SPRITE_APPS)
- ->setName(pht('View Tasks'))
- ->setHref($view_uri),
- id(new PhabricatorActionView())
- ->setName(pht("Add Task"))
- ->setIcon('create')
- ->setHref($create_uri),
- );
- }
-
-
}
diff --git a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
--- a/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
+++ b/src/applications/maniphest/query/ManiphestTaskSearchEngine.php
@@ -50,7 +50,7 @@
$saved->setParameter(
'allProjectPHIDs',
- $request->getArr('allProjects'));
+ $this->readPHIDsFromRequest($request, 'allProjects'));
$saved->setParameter(
'withNoProject',
@@ -58,11 +58,11 @@
$saved->setParameter(
'anyProjectPHIDs',
- $request->getArr('anyProjects'));
+ $this->readPHIDsFromRequest($request, 'anyProjects'));
$saved->setParameter(
'excludeProjectPHIDs',
- $request->getArr('excludeProjects'));
+ $this->readPHIDsFromRequest($request, 'excludeProjects'));
$saved->setParameter(
'userProjectPHIDs',
diff --git a/src/applications/project/controller/PhabricatorProjectProfileController.php b/src/applications/project/controller/PhabricatorProjectProfileController.php
--- a/src/applications/project/controller/PhabricatorProjectProfileController.php
+++ b/src/applications/project/controller/PhabricatorProjectProfileController.php
@@ -148,7 +148,7 @@
$phid = $project->getPHID();
$view_uri = urisprintf(
- '/maniphest/?statuses=%s&allProjects[]=%s#R',
+ '/maniphest/?statuses=%s&allProjects=%s#R',
implode(',', ManiphestTaskStatus::getOpenStatusConstants()),
$phid);
$create_uri = '/maniphest/task/create/?projects='.$phid;

File Metadata

Mime Type
text/plain
Expires
Fri, Dec 20, 9:47 AM (21 h, 49 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6910105
Default Alt Text
D9042.diff (5 KB)

Event Timeline

Phabricator · Built by Phacility