Use bracket-free, human-readable query URIs everywhere
ClosedPublic
Actions

Authored by epriestley on May 10 2014, 3:13 PM.

Details

Reviewers

btrahan

Commits

Restricted Diffusion Commit
rPb64415c9b138: Use bracket-free, human-readable query URIs everywhere

Summary

See http://fab.wmflabs.org/T88. While this issue is on MW's side, these links are kind of ugly and have more readable alternate forms now. Update them to use proper modern forms.

Test Plan

See inlines.

Diff Detail

Repository

rP Phabricator

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 21474.May 10 2014, 3:13 PM

epriestley retitled this revision from to Use bracket-free, human-readable query URIs everywhere.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: btrahan.

Herald added a subscriber: epriestley. · View Herald TranscriptMay 10 2014, 3:13 PM

Harbormaster completed remote builds in B345: Diff 21474.May 10 2014, 3:14 PM

epriestley added inline comments.May 10 2014, 3:16 PM

src/applications/differential/event/DifferentialActionMenuEventListener.php
36–40	Clicked the link on my profile. We don't need to make this a form anymore, I think that was a leftover from a very long time ago before ApplicationSearch.
src/applications/home/controller/PhabricatorHomeMainController.php
151–154	This was buggy anyway on installs with more than "open" status option, since `statuses[]=a,b` is not a valid construction.
198–199	This should be `urisprintf()`, I'll fix that locally...
199–200	Same as above, buggy with more than one open status.
src/applications/maniphest/event/ManiphestActionMenuEventListener.php
47	This has no callsite, and wasn't updated for configurable statuses.