Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14124223
D20565.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
829 B
Referenced Files
None
Subscribers
None
D20565.diff
View Options
diff --git a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionCloseTransaction.php
@@ -44,6 +44,11 @@
$object->setProperty(
DifferentialRevision::PROPERTY_CLOSED_FROM_ACCEPTED,
$was_accepted);
+
+ // See T13300. When a revision is closed, we promote it out of "Draft"
+ // immediately. This usually happens when a user creates a draft revision
+ // and then lands the associated commit before the revision leaves draft.
+ $object->setShouldBroadcast(true);
}
protected function validateAction($object, PhabricatorUser $viewer) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Dec 1, 2:05 AM (19 h, 32 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6811262
Default Alt Text
D20565.diff (829 B)
Attached To
Mode
D20565: When a revision is closed, always promote it out of draft
Attached
Detach File
Event Timeline
Log In to Comment