D19286.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D19286.diff
View Options

	diff --git a/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php b/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
	--- a/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
	+++ b/src/applications/differential/xaction/DifferentialRevisionUpdateTransaction.php
	@@ -13,8 +13,14 @@
	public function applyInternalEffects($object, $value) {
	$should_review = $this->shouldRequestReviewAfterUpdate($object);
	if ($should_review) {
	- $object->setModernRevisionStatus(
	- DifferentialRevisionStatus::NEEDS_REVIEW);
	+ // If we're updating a non-broadcasting revision, put it back in draft
	+ // rather than moving it directly to "Needs Review".
	+ if ($object->getShouldBroadcast()) {
	+ $new_status = DifferentialRevisionStatus::NEEDS_REVIEW;
	+ } else {
	+ $new_status = DifferentialRevisionStatus::DRAFT;
	+ }
	+ $object->setModernRevisionStatus($new_status);
	}

	$editor = $this->getEditor();