Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14090472
D19558.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
898 B
Referenced Files
None
Subscribers
None
D19558.diff
View Options
diff --git a/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php b/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php
--- a/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php
+++ b/src/applications/diffusion/conduit/DiffusionGetRecentCommitsByPathConduitAPIMethod.php
@@ -23,6 +23,12 @@
);
}
+ protected function defineErrorTypes() {
+ return array(
+ 'ERR_NOT_FOUND' => pht('Repository was not found.'),
+ );
+ }
+
protected function defineReturnType() {
return 'nonempty list<string>';
}
@@ -36,6 +42,10 @@
'branch' => $request->getValue('branch'),
));
+ if ($drequest === null) {
+ throw new ConduitException('ERR_NOT_FOUND');
+ }
+
$limit = nonempty(
$request->getValue('limit'),
self::DEFAULT_LIMIT);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Mon, Nov 25, 6:11 PM (21 h, 12 m)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6786594
Default Alt Text
D19558.diff (898 B)
Attached To
Mode
D19558: Gracefully fail request if non existing callsign is passed to getrecentcommitsbypath instead of crashing
Attached
Detach File
Event Timeline
Log In to Comment