Page MenuHomePhabricator
Files F14053372

D8509.diff
No OneTemporary
Actions

D8509.diff
View Options

diff --git a/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php b/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
--- a/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
+++ b/src/applications/diffusion/controller/DiffusionRepositoryEditActionsController.php
@@ -75,7 +75,8 @@
"Normally, Phabricator publishes notifications when it discovers ".
"new commits. You can disable publishing for this repository by ".
"turning off **Notify/Publish**. This will disable notifications, ".
- "feed, and Herald for this repository.".
+ "feed, and Herald (including audits and build plans) for this ".
+ "repository.".
"\n\n".
"When Phabricator discovers a new commit, it can automatically ".
"close associated revisions and tasks. If you don't want ".
diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
--- a/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
+++ b/src/applications/repository/worker/PhabricatorRepositoryCommitHeraldWorker.php
@@ -33,6 +33,10 @@
return;
}
+ if ($repository->getDetail('herald-disabled')) {
+ return;
+ }
+
$data = id(new PhabricatorRepositoryCommitData())->loadOneWhere(
'commitID = %d',
$commit->getID());
@@ -75,11 +79,6 @@
$explicit_auditors = $this->createAuditsFromCommitMessage($commit, $data);
- if ($repository->getDetail('herald-disabled')) {
- // This just means "disable email"; audits are (mostly) idempotent.
- return;
- }
-
$this->publishFeedStory($repository, $commit, $data);
$herald_targets = $adapter->getEmailPHIDs();
diff --git a/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php b/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
--- a/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
+++ b/src/applications/repository/worker/PhabricatorRepositoryCommitOwnersWorker.php
@@ -7,6 +7,10 @@
PhabricatorRepository $repository,
PhabricatorRepositoryCommit $commit) {
+ if ($repository->getDetail('herald-disabled')) {
+ return;
+ }
+
$affected_paths = PhabricatorOwnerPathQuery::loadAffectedPaths(
$repository,
$commit,

File Metadata

Mime Type
text/plain
Expires
Sat, Nov 16, 3:09 PM (2 d, 23 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6720204
Default Alt Text
D8509.diff (2 KB)

Event Timeline

Phabricator · Built by Phacility