Page MenuHomePhabricator

Disable Herald more aggressively when it's turned off for a repository
ClosedPublic

Authored by epriestley on Mar 12 2014, 10:41 PM.

Details

Summary

Currently, disabling Herald only disables feed, notifications and email. Historically, audits didn't really create external effects so it made sense for Herald to only partially disable itself.

With the advent of Harbormaster/Build Plans, it makes more sense for Herald to just stop doing anything. When this option is disabled, stop all audit/build/publish/feed/email actions for the repository.

Test Plan

Ran scripts/repository/reparse.php --herald, etc.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Disable Herald more aggressively when it's turned off for a repository.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, dctrwatson.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 13 2014, 12:56 AM
epriestley updated this revision to Diff 20200.

Closed by commit rPd27cd5fb9902 (authored by @epriestley).