Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14046762
D15746.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D15746.diff
View Options
diff --git a/resources/sql/autopatches/20160418.repouri.2.sql b/resources/sql/autopatches/20160418.repouri.2.sql
new file mode 100644
--- /dev/null
+++ b/resources/sql/autopatches/20160418.repouri.2.sql
@@ -0,0 +1,2 @@
+ALTER TABLE {$NAMESPACE}_repository.repository_uri
+ ADD credentialPHID VARBINARY(64);
diff --git a/src/applications/repository/storage/PhabricatorRepositoryURI.php b/src/applications/repository/storage/PhabricatorRepositoryURI.php
--- a/src/applications/repository/storage/PhabricatorRepositoryURI.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryURI.php
@@ -40,6 +40,7 @@
'uri' => 'text255',
'builtinProtocol' => 'text32?',
'builtinIdentifier' => 'text32?',
+ 'credentialPHID' => 'phid?',
'ioType' => 'text32',
'displayType' => 'text32',
'isDisabled' => 'bool',
diff --git a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
--- a/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
+++ b/src/infrastructure/storage/management/workflow/PhabricatorStorageManagementWorkflow.php
@@ -61,7 +61,7 @@
}
}
- $this->didExecute($args);
+ return $this->didExecute($args);
}
public function didExecute(PhutilArgumentParser $args) {}
@@ -81,13 +81,15 @@
$lock = $this->lock();
try {
- $this->doAdjustSchemata($unsafe);
+ $err = $this->doAdjustSchemata($unsafe);
} catch (Exception $ex) {
$lock->unlock();
throw $ex;
}
$lock->unlock();
+
+ return $err;
}
final private function doAdjustSchemata($unsafe) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Nov 14, 11:37 PM (3 d, 19 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6722424
Default Alt Text
D15746.diff (1 KB)
Attached To
Mode
D15746: Correct RepositoryURI schema and propagate `adjust` exit code correctly
Attached
Detach File
Event Timeline
Log In to Comment