Page MenuHomePhabricator

D13919.diff
No OneTemporary

D13919.diff

diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php
--- a/src/applications/diffusion/controller/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseController.php
@@ -183,8 +183,6 @@
$ownership = id(new PHUIStatusListView())
->setUser($viewer);
-
-
foreach ($packages as $package) {
$icon = 'fa-list-alt';
$color = 'grey';
diff --git a/src/applications/owners/query/PhabricatorOwnersPackageQuery.php b/src/applications/owners/query/PhabricatorOwnersPackageQuery.php
--- a/src/applications/owners/query/PhabricatorOwnersPackageQuery.php
+++ b/src/applications/owners/query/PhabricatorOwnersPackageQuery.php
@@ -42,6 +42,7 @@
}
foreach ($paths as $path) {
+ $path = (string)$path;
$this->controlMap[$repository_phid][$path] = $path;
}
@@ -277,6 +278,8 @@
* @return list<PhabricatorOwnersPackage> List of controlling packages.
*/
public function getControllingPackagesForPath($repository_phid, $path) {
+ $path = (string)$path;
+
if (!isset($this->controlMap[$repository_phid][$path])) {
throw new PhutilInvalidStateException('withControl');
}

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 13, 11:43 AM (1 d, 4 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6719401
Default Alt Text
D13919.diff (1 KB)

Event Timeline