Page MenuHomePhabricator

D11399.id27376.diff
No OneTemporary

D11399.id27376.diff

diff --git a/src/__phutil_library_map__.php b/src/__phutil_library_map__.php
--- a/src/__phutil_library_map__.php
+++ b/src/__phutil_library_map__.php
@@ -5214,6 +5214,7 @@
'PhabricatorOAuthServerClient' => array(
'PhabricatorOAuthServerDAO',
'PhabricatorPolicyInterface',
+ 'PhabricatorDestructibleInterface',
),
'PhabricatorOAuthServerClientAuthorizationPHIDType' => 'PhabricatorPHIDType',
'PhabricatorOAuthServerClientPHIDType' => 'PhabricatorPHIDType',
@@ -5350,6 +5351,7 @@
'PhabricatorPolicy' => array(
'PhabricatorPolicyDAO',
'PhabricatorPolicyInterface',
+ 'PhabricatorDestructibleInterface',
),
'PhabricatorPolicyApplication' => 'PhabricatorApplication',
'PhabricatorPolicyAwareQuery' => 'PhabricatorOffsetPagedQuery',
diff --git a/src/applications/config/option/PhabricatorPHDConfigOptions.php b/src/applications/config/option/PhabricatorPHDConfigOptions.php
--- a/src/applications/config/option/PhabricatorPHDConfigOptions.php
+++ b/src/applications/config/option/PhabricatorPHDConfigOptions.php
@@ -63,6 +63,14 @@
"ENORMOUS amount of output, but can help debug issues. Daemons ".
"launched in debug mode with 'phd debug' are always launched in ".
"trace mdoe. See also 'phd.verbose'.")),
+ $this->newOption('phd.variant-config', 'list<string>', array())
+ ->setDescription(
+ pht(
+ 'Specify config keys that can safely vary between the web tier '.
+ 'and the daemons. Primarily, this is a way to suppress the '.
+ '[[ %s | %s ]] setup issue on a per config key basis.',
+ '/config/issue/daemons.need-restarting/',
+ pht('Daemons and Web Have Different Config'))),
);
}
diff --git a/src/infrastructure/env/PhabricatorEnv.php b/src/infrastructure/env/PhabricatorEnv.php
--- a/src/infrastructure/env/PhabricatorEnv.php
+++ b/src/infrastructure/env/PhabricatorEnv.php
@@ -234,6 +234,9 @@
$keys = array_keys(self::getAllConfigKeys());
ksort($keys);
+ $skip_keys = self::getEnvConfig('phd.variant-config');
+ $keys = array_diff($keys, $skip_keys);
+
$values = array();
foreach ($keys as $key) {
$values[$key] = self::getEnvConfigIfExists($key);
@@ -312,7 +315,8 @@
return $path;
}
- $production_domain = self::getEnvConfig('phabricator.production-uri');
+ $production_domain =
+ self::getEnvConfigIfExists('phabricator.production-uri');
if (!$production_domain) {
$production_domain = self::getAnyBaseURI();
}
@@ -376,7 +380,7 @@
}
public static function getAnyBaseURI() {
- $base_uri = self::getEnvConfig('phabricator.base-uri');
+ $base_uri = self::getEnvConfigIfExists('phabricator.base-uri');
if (!$base_uri) {
$base_uri = self::getRequestBaseURI();

File Metadata

Mime Type
text/plain
Expires
Wed, Nov 13, 3:55 AM (1 d, 9 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6756753
Default Alt Text
D11399.id27376.diff (2 KB)

Event Timeline