Page MenuHomePhabricator

Config - add phd.variant-config to suppress "Daemon & Web config" error message on a per key basis
ClosedPublic

Authored by btrahan on Jan 14 2015, 9:09 PM.
Tags
None
Referenced Files
F13325417: D11399.diff
Sat, Jun 15, 1:49 AM
F13312920: D11399.diff
Tue, Jun 11, 7:18 AM
F13299465: D11399.diff
Fri, Jun 7, 8:02 AM
F13282102: D11399.diff
Sun, Jun 2, 11:42 AM
F13264405: D11399.id27376.diff
Mon, May 27, 4:48 PM
F13243687: D11399.diff
Thu, May 23, 4:07 AM
F13222112: D11399.diff
Sun, May 19, 3:21 AM
F13204642: D11399.diff
May 15 2024, 12:47 AM
Subscribers

Details

Summary

Fixes T6959.

Test Plan

When I was ready to test the feature, the "Daemon & Web config" error already showed up, from having added phd.variant-config. I went meta and changed the value of phd.variant-config to have phd.variant-config. The config error disappeared. I then changed the conpherence setting about conpherence email prefix and the error showed up again. Removing the conpherence config setting made the error disappear once more.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

btrahan retitled this revision from to Config - add phd.variant-config to suppress "Daemon & Web config" error message on a per key basis.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added a reviewer: epriestley.
src/infrastructure/env/PhabricatorEnv.php
319

This is some unrelated stuff I should maybe remove. I don't have base-uri or production-uri set in my config, so this code throws an exception with just getEvnConfig... (I hit these codepaths trying to make a link in the new phd.variant-config description)

src/applications/config/option/PhabricatorPHDConfigOptions.php
72

This link won't be very useful if the issue doesn't exist, since it will just say "This setup issue has been resolved.". Not sure if it's helpful or not on the balance.

src/infrastructure/env/PhabricatorEnv.php
235–238

(Unrelated, but I think this should just be sort()?)

319

This is unexpected -- getEnvConfig() should not throw if these values are null, only if they aren't declared anywhere. Do you have a copy of the exception/trace?

src/infrastructure/env/PhabricatorEnv.php
319

I get one of those new fangled purdy error pages without any trace in the logs. Is there something I should do to have the logging occur?

In any case, I'll back these bits out for this diff, as it should be a separate diff anyway.

address other feedback (remove the link and just say "Daemon & Web issue"; change ksort to sort and verify that is okay because "Daemon & Web" issue did not show up)

epriestley edited edge metadata.
This revision is now accepted and ready to land.Jan 14 2015, 9:45 PM
This revision was automatically updated to reflect the committed changes.