Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14040248
D12907.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
849 B
Referenced Files
None
Subscribers
None
D12907.diff
View Options
diff --git a/src/applications/system/engine/PhabricatorDestructionEngine.php b/src/applications/system/engine/PhabricatorDestructionEngine.php
--- a/src/applications/system/engine/PhabricatorDestructionEngine.php
+++ b/src/applications/system/engine/PhabricatorDestructionEngine.php
@@ -116,13 +116,14 @@
}
private function destroyNotifications($object_phid) {
- $notifications = id(new PhabricatorFeedStoryNotification())->loadAllWhere(
- 'primaryObjectPHID = %s',
- $object_phid);
+ $table = id(new PhabricatorFeedStoryNotification());
+ $conn_w = $table->establishConnection('w');
- foreach ($notifications as $notification) {
- $notification->delete();
- }
+ queryfx(
+ $conn_w,
+ 'DELETE FROM %T WHERE primaryObjectPHID = %s',
+ $table->getTableName(),
+ $object_phid);
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Tue, Nov 12, 8:23 AM (6 d, 20 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6727480
Default Alt Text
D12907.diff (849 B)
Attached To
Mode
D12907: Destroy notifications properly from `bin/remove destroy`
Attached
Detach File
Event Timeline
Log In to Comment