Page MenuHomePhabricator

D17897.diff
No OneTemporary

D17897.diff

diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
--- a/src/applications/base/controller/PhabricatorController.php
+++ b/src/applications/base/controller/PhabricatorController.php
@@ -471,7 +471,7 @@
->setViewer($this->getViewer());
}
- public function newCurtainView($object) {
+ public function newCurtainView($object = null) {
$viewer = $this->getViewer();
$action_id = celerity_generate_unique_node_id();
@@ -491,9 +491,11 @@
->setViewer($viewer)
->setActionList($action_list);
- $panels = PHUICurtainExtension::buildExtensionPanels($viewer, $object);
- foreach ($panels as $panel) {
- $curtain->addPanel($panel);
+ if ($object) {
+ $panels = PHUICurtainExtension::buildExtensionPanels($viewer, $object);
+ foreach ($panels as $panel) {
+ $curtain->addPanel($panel);
+ }
}
return $curtain;
diff --git a/src/applications/project/controller/PhabricatorProjectMembersViewController.php b/src/applications/project/controller/PhabricatorProjectMembersViewController.php
--- a/src/applications/project/controller/PhabricatorProjectMembersViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectMembersViewController.php
@@ -70,7 +70,7 @@
$viewer = $this->getViewer();
$id = $project->getID();
- $curtain = $this->newCurtainView($project);
+ $curtain = $this->newCurtainView();
$is_locked = $project->getIsMembershipLocked();
diff --git a/src/applications/project/controller/PhabricatorProjectSubprojectsController.php b/src/applications/project/controller/PhabricatorProjectSubprojectsController.php
--- a/src/applications/project/controller/PhabricatorProjectSubprojectsController.php
+++ b/src/applications/project/controller/PhabricatorProjectSubprojectsController.php
@@ -203,7 +203,7 @@
$allows_milestones = $project->supportsMilestones();
$allows_subprojects = $project->supportsSubprojects();
- $curtain = $this->newCurtainView($project);
+ $curtain = $this->newCurtainView();
if ($allows_milestones && $milestones) {
$milestone_text = pht('Create Next Milestone');

File Metadata

Mime Type
text/plain
Expires
Tue, Nov 12, 2:00 AM (2 d, 3 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6737678
Default Alt Text
D17897.diff (2 KB)

Event Timeline