Paths

Table of Contentst

Differential D17897

Make passing an object to newCurtain optional
ClosedPublic
Actions

Authored by chad on May 16 2017, 2:58 AM.

Tags

None

Referenced Files

	F14082412: D17897.diff
	Fri, Nov 22, 11:44 PM

	Unknown Object (File)
	Tue, Nov 19, 2:53 PM

	Unknown Object (File)
	Fri, Nov 15, 11:47 AM

	Unknown Object (File)
	Thu, Nov 14, 7:02 PM

	Unknown Object (File)
	Mon, Nov 11, 2:00 AM

	Unknown Object (File)
	Sun, Nov 10, 1:11 PM

	Unknown Object (File)
	Sun, Nov 10, 12:56 PM

	Unknown Object (File)
	Sun, Nov 10, 10:43 AM

View All 94 Files

Subscribers

Details

Reviewers

Commits

rPbf753c8b5a08: Make passing an object to newCurtain optional

Summary

We seem to already support this, just takes it fully there. We don't need to see things like "Flag", etc, on certain subpages of projects/people/etc.

Test Plan

Review Members, Subproject pages, no longer see "Flag for Later" which only is for the Project itself. Check manage, still there.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

chad created this revision.May 16 2017, 2:58 AM

Herald added a subscriber: Korvin. · View Herald TranscriptMay 16 2017, 2:58 AM

Harbormaster completed remote builds in B16968: Diff 43041.May 16 2017, 2:59 AM

epriestley accepted this revision.May 16 2017, 9:52 AM

epriestley added inline comments.

src/applications/base/controller/PhabricatorController.php
493–499	Consider skipping this if `$object` is `null` -- some extension might run into trouble assuming that `$object` will always actually be an object.

This revision is now accepted and ready to land.May 16 2017, 9:52 AM

good call

Closed by commit rPbf753c8b5a08: Make passing an object to newCurtain optional (authored by chad, committed by chad). · Explain WhyMay 16 2017, 3:51 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

controller/

PhabricatorController.php

10 lines

project/

controller/

PhabricatorProjectMembersViewController.php

2 lines

PhabricatorProjectSubprojectsController.php

2 lines

Diff 43077

src/applications/base/controller/PhabricatorController.php

Loading...

src/applications/project/controller/PhabricatorProjectMembersViewController.php

Loading...

src/applications/project/controller/PhabricatorProjectSubprojectsController.php

Loading...