Page MenuHomePhabricator

D11915.diff
No OneTemporary

D11915.diff

diff --git a/src/applications/files/controller/PhabricatorFileDataController.php b/src/applications/files/controller/PhabricatorFileDataController.php
--- a/src/applications/files/controller/PhabricatorFileDataController.php
+++ b/src/applications/files/controller/PhabricatorFileDataController.php
@@ -73,9 +73,13 @@
// if the user can see the file, generate a token;
// redirect to the alt domain with the token;
+ $token_uri = $file->getCDNURIWithToken();
+ $token_uri = new PhutilURI($token_uri);
+ $token_uri = $this->addURIParameters($token_uri);
+
return id(new AphrontRedirectResponse())
->setIsExternal(true)
- ->setURI($file->getCDNURIWithToken());
+ ->setURI($token_uri);
} else {
// We are using the alternate domain
@@ -93,7 +97,7 @@
$acquire_token_uri = id(new PhutilURI($file->getViewURI()))
->setDomain($main_domain);
-
+ $acquire_token_uri = $this->addURIParameters($acquire_token_uri);
if ($this->token) {
// validate the token, if it is valid, continue
@@ -186,4 +190,19 @@
return $response;
}
+
+ /**
+ * Add passthrough parameters to the URI so they aren't lost when we
+ * redirect to acquire tokens.
+ */
+ private function addURIParameters(PhutilURI $uri) {
+ $request = $this->getRequest();
+
+ if ($request->getBool('download')) {
+ $uri->setQueryParam('download', 1);
+ }
+
+ return $uri;
+ }
+
}

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 11, 11:41 PM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6710509
Default Alt Text
D11915.diff (1 KB)

Event Timeline