Page MenuHomePhabricator

D8876.id21058.diff
No OneTemporary

D8876.id21058.diff

diff --git a/src/applications/audit/view/PhabricatorAuditListView.php b/src/applications/audit/view/PhabricatorAuditListView.php
--- a/src/applications/audit/view/PhabricatorAuditListView.php
+++ b/src/applications/audit/view/PhabricatorAuditListView.php
@@ -92,7 +92,6 @@
$rowc = array();
$list = new PHUIObjectItemListView();
- $authority = array_fill_keys($this->authorityPHIDs, true);
foreach ($this->commits as $commit) {
$commit_phid = $commit->getPHID();
$commit_handle = $this->getHandle($commit_phid);
@@ -113,7 +112,12 @@
}
$auditors = phutil_implode_html(', ', $auditors);
- $audit = idx($audits, $user->getPHID());
+ $authority_audits = array_select_keys($audits, $this->authorityPHIDs);
+ if ($authority_audits) {
+ $audit = reset($authority_audits);
+ } else {
+ $audit = reset($audits);
+ }
if ($audit) {
$reasons = $audit->getAuditReasons();
$reasons = phutil_implode_html(', ', $reasons);
@@ -143,9 +147,10 @@
$item->addAttribute(pht('Auditors: %s', $auditors));
}
+ /* TODO - what is the right heuristic?
if ($commit->getAuthorityAudits($user, $this->authorityPHIDs)) {
$item->setEffect('highlighted');
- }
+ }*/
$list->addItem($item);
}

File Metadata

Mime Type
text/plain
Expires
Mon, Nov 11, 1:34 AM (1 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6721908
Default Alt Text
D8876.id21058.diff (1 KB)

Event Timeline