Page MenuHomePhabricator

Audit - polish list view a bit
ClosedPublic

Authored by btrahan on Apr 27 2014, 8:36 PM.
Tags
None
Referenced Files
Unknown Object (File)
Thu, Apr 25, 12:00 AM
Unknown Object (File)
Thu, Apr 25, 12:00 AM
Unknown Object (File)
Wed, Apr 24, 11:53 PM
Unknown Object (File)
Tue, Apr 23, 9:28 AM
Unknown Object (File)
Tue, Apr 23, 1:27 AM
Unknown Object (File)
Feb 5 2024, 9:04 PM
Unknown Object (File)
Feb 5 2024, 12:00 PM
Unknown Object (File)
Feb 5 2024, 9:04 AM
Subscribers

Details

Reviewers
epriestley
chad
Commits
Restricted Diffusion Commit
rP0db6aad80d56: Audit - polish list view a bit
Summary

Grab an audit we have authority over if possible, relying on how that's sorted by actor first. This gets us the best description possible of what the audit is about in the list. Also sort out highlighting; right now it looks silly on some views when everything is highlighted.

An open question in the diff - when to highlight audits?

Options I see -

  • never
  • don't do it on "needs attention" but other views
  • calculate what percentage of shown audits user has authority over, if most ( > N% ) don't highlight, otherwise highlight
  • something else
  • some combo of the above
Test Plan

lists of audits looked better

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

btrahan retitled this revision from to Audit - polish list view a bit.
btrahan updated this object.
btrahan edited the test plan for this revision. (Show Details)
btrahan added reviewers: epriestley, chad.

I'd say let's try "never"? We don't highlight stuff in Differential, and I think this is usually available from context.

epriestley edited edge metadata.

Suggest "never" until we come up with a stronger reason to pick another rule.

This revision is now accepted and ready to land.Apr 27 2014, 11:30 PM
btrahan updated this revision to Diff 21068.

Closed by commit rP0db6aad80d56 (authored by @btrahan).