Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14034183
D17163.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
741 B
Referenced Files
None
Subscribers
None
D17163.diff
View Options
diff --git a/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php b/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
--- a/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
+++ b/src/applications/differential/xaction/DifferentialRevisionReviewersTransaction.php
@@ -24,7 +24,13 @@
// First, remove any reviewers we're getting rid of.
$rem = idx($value, '-', array());
$rem = $datasource->evaluateTokens($rem);
- foreach ($rem as $phid) {
+ foreach ($rem as $spec) {
+ if (!is_array($spec)) {
+ $phid = $spec;
+ } else {
+ $phid = $spec['phid'];
+ }
+
unset($reviewers[$phid]);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 10, 10:35 PM (1 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6709598
Default Alt Text
D17163.diff (741 B)
Attached To
Mode
D17163: Fix an issue which could prevent blocking reviewers from being removed from revisions
Attached
Detach File
Event Timeline
Log In to Comment