Page MenuHomePhabricator
Files F14029088

D18753.diff
No OneTemporary
Actions

D18753.diff
View Options

diff --git a/resources/celerity/map.php b/resources/celerity/map.php
--- a/resources/celerity/map.php
+++ b/resources/celerity/map.php
@@ -13,7 +13,7 @@
'core.pkg.js' => '4c79d74f',
'darkconsole.pkg.js' => '1f9a31bc',
'differential.pkg.css' => '45951e9e',
- 'differential.pkg.js' => 'b71b8c5d',
+ 'differential.pkg.js' => 'ae6460e0',
'diffusion.pkg.css' => 'a2d17c7d',
'diffusion.pkg.js' => '6134c5a1',
'favicon.ico' => '30672e08',
@@ -444,7 +444,7 @@
'rsrc/js/application/releeph/releeph-preview-branch.js' => 'b2b4fbaf',
'rsrc/js/application/releeph/releeph-request-state-change.js' => 'a0b57eb8',
'rsrc/js/application/releeph/releeph-request-typeahead.js' => 'de2e896f',
- 'rsrc/js/application/repository/repository-crossreference.js' => 'e5339c43',
+ 'rsrc/js/application/repository/repository-crossreference.js' => '7fe9bc12',
'rsrc/js/application/search/behavior-reorder-profile-menu-items.js' => 'e2e0a072',
'rsrc/js/application/search/behavior-reorder-queries.js' => 'e9581f08',
'rsrc/js/application/slowvote/behavior-slowvote-embed.js' => '887ad43f',
@@ -690,7 +690,7 @@
'javelin-behavior-reorder-applications' => '76b9fc3e',
'javelin-behavior-reorder-columns' => 'e1d25dfb',
'javelin-behavior-reorder-profile-menu-items' => 'e2e0a072',
- 'javelin-behavior-repository-crossreference' => 'e5339c43',
+ 'javelin-behavior-repository-crossreference' => '7fe9bc12',
'javelin-behavior-scrollbar' => '834a1173',
'javelin-behavior-search-reorder-queries' => 'e9581f08',
'javelin-behavior-select-content' => 'bf5374ef',
@@ -1546,6 +1546,12 @@
'7f243deb' => array(
'javelin-install',
),
+ '7fe9bc12' => array(
+ 'javelin-behavior',
+ 'javelin-dom',
+ 'javelin-stratcom',
+ 'javelin-uri',
+ ),
'834a1173' => array(
'javelin-behavior',
'javelin-scrollbar',
@@ -2073,12 +2079,6 @@
'javelin-behavior',
'javelin-dom',
),
- 'e5339c43' => array(
- 'javelin-behavior',
- 'javelin-dom',
- 'javelin-stratcom',
- 'javelin-uri',
- ),
'e5822781' => array(
'javelin-behavior',
'javelin-dom',
diff --git a/webroot/rsrc/js/application/repository/repository-crossreference.js b/webroot/rsrc/js/application/repository/repository-crossreference.js
--- a/webroot/rsrc/js/application/repository/repository-crossreference.js
+++ b/webroot/rsrc/js/application/repository/repository-crossreference.js
@@ -46,8 +46,19 @@
if (!isSignalkey(e)) {
return;
}
+
+ var target = e.getTarget();
+
+ try {
+ // If we're in an inline comment, don't link symbols.
+ if (JX.DOM.findAbove(target, 'div', 'differential-inline-comment')) {
+ return;
+ }
+ } catch (ex) {
+ // Continue if we're not inside an inline comment.
+ }
+
if (e.getType() === 'mouseover') {
- var target = e.getTarget();
while (target !== document.body) {
if (JX.DOM.isNode(target, 'span') &&
(target.className in class_map)) {
@@ -58,7 +69,7 @@
target = target.parentNode;
}
} else if (e.getType() === 'click') {
- openSearch(e.getTarget(), lang);
+ openSearch(target, lang);
}
});
}

File Metadata

Mime Type
text/plain
Expires
Sat, Nov 9, 7:21 PM (1 w, 15 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6723327
Default Alt Text
D18753.diff (3 KB)

Event Timeline

Phabricator · Built by Phacility