Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14027094
D13919.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D13919.diff
View Options
diff --git a/src/applications/diffusion/controller/DiffusionBrowseController.php b/src/applications/diffusion/controller/DiffusionBrowseController.php
--- a/src/applications/diffusion/controller/DiffusionBrowseController.php
+++ b/src/applications/diffusion/controller/DiffusionBrowseController.php
@@ -183,8 +183,6 @@
$ownership = id(new PHUIStatusListView())
->setUser($viewer);
-
-
foreach ($packages as $package) {
$icon = 'fa-list-alt';
$color = 'grey';
diff --git a/src/applications/owners/query/PhabricatorOwnersPackageQuery.php b/src/applications/owners/query/PhabricatorOwnersPackageQuery.php
--- a/src/applications/owners/query/PhabricatorOwnersPackageQuery.php
+++ b/src/applications/owners/query/PhabricatorOwnersPackageQuery.php
@@ -42,6 +42,7 @@
}
foreach ($paths as $path) {
+ $path = (string)$path;
$this->controlMap[$repository_phid][$path] = $path;
}
@@ -277,6 +278,8 @@
* @return list<PhabricatorOwnersPackage> List of controlling packages.
*/
public function getControllingPackagesForPath($repository_phid, $path) {
+ $path = (string)$path;
+
if (!isset($this->controlMap[$repository_phid][$path])) {
throw new PhutilInvalidStateException('withControl');
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 9, 5:07 AM (5 d, 11 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6719401
Default Alt Text
D13919.diff (1 KB)
Attached To
Mode
D13919: Fix Owners lookups for the repository root
Attached
Detach File
Event Timeline
Log In to Comment