Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14026303
D7507.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D7507.diff
View Options
Index: src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
===================================================================
--- src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
+++ src/aphront/configuration/AphrontDefaultApplicationConfiguration.php
@@ -222,6 +222,7 @@
$response = new AphrontWebpageResponse();
$response->setContent($view->render());
+ $response->setHTTPResponseCode(500);
return $response;
}
@@ -268,6 +269,7 @@
$response = new AphrontDialogResponse();
$response->setDialog($dialog);
+ $response->setHTTPResponseCode(500);
return $response;
}
Index: src/applications/base/controller/PhabricatorController.php
===================================================================
--- src/applications/base/controller/PhabricatorController.php
+++ src/applications/base/controller/PhabricatorController.php
@@ -249,9 +249,10 @@
$view->appendChild(hsprintf(
'<div style="padding: 2em 0;">%s</div>',
$response->buildResponseString()));
- $response = new AphrontWebpageResponse();
- $response->setContent($view->render());
- return $response;
+ $page_response = new AphrontWebpageResponse();
+ $page_response->setContent($view->render());
+ $page_response->setHTTPResponseCode($response->getHTTPResponseCode());
+ return $page_response;
} else {
$response->getDialog()->setIsStandalone(true);
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 9, 12:54 AM (4 d, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6726823
Default Alt Text
D7507.diff (1 KB)
Attached To
Mode
D7507: Return HTTP 500, not HTTP 200, on exception pages
Attached
Detach File
Event Timeline
Log In to Comment