Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14023339
D17897.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
2 KB
Referenced Files
None
Subscribers
None
D17897.diff
View Options
diff --git a/src/applications/base/controller/PhabricatorController.php b/src/applications/base/controller/PhabricatorController.php
--- a/src/applications/base/controller/PhabricatorController.php
+++ b/src/applications/base/controller/PhabricatorController.php
@@ -471,7 +471,7 @@
->setViewer($this->getViewer());
}
- public function newCurtainView($object) {
+ public function newCurtainView($object = null) {
$viewer = $this->getViewer();
$action_id = celerity_generate_unique_node_id();
@@ -491,9 +491,11 @@
->setViewer($viewer)
->setActionList($action_list);
- $panels = PHUICurtainExtension::buildExtensionPanels($viewer, $object);
- foreach ($panels as $panel) {
- $curtain->addPanel($panel);
+ if ($object) {
+ $panels = PHUICurtainExtension::buildExtensionPanels($viewer, $object);
+ foreach ($panels as $panel) {
+ $curtain->addPanel($panel);
+ }
}
return $curtain;
diff --git a/src/applications/project/controller/PhabricatorProjectMembersViewController.php b/src/applications/project/controller/PhabricatorProjectMembersViewController.php
--- a/src/applications/project/controller/PhabricatorProjectMembersViewController.php
+++ b/src/applications/project/controller/PhabricatorProjectMembersViewController.php
@@ -70,7 +70,7 @@
$viewer = $this->getViewer();
$id = $project->getID();
- $curtain = $this->newCurtainView($project);
+ $curtain = $this->newCurtainView();
$is_locked = $project->getIsMembershipLocked();
diff --git a/src/applications/project/controller/PhabricatorProjectSubprojectsController.php b/src/applications/project/controller/PhabricatorProjectSubprojectsController.php
--- a/src/applications/project/controller/PhabricatorProjectSubprojectsController.php
+++ b/src/applications/project/controller/PhabricatorProjectSubprojectsController.php
@@ -203,7 +203,7 @@
$allows_milestones = $project->supportsMilestones();
$allows_subprojects = $project->supportsSubprojects();
- $curtain = $this->newCurtainView($project);
+ $curtain = $this->newCurtainView();
if ($allows_milestones && $milestones) {
$milestone_text = pht('Create Next Milestone');
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Nov 8, 1:10 AM (5 d, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6737678
Default Alt Text
D17897.diff (2 KB)
Attached To
Mode
D17897: Make passing an object to newCurtain optional
Attached
Detach File
Event Timeline
Log In to Comment