Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14013296
D15409.id37149.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
12 KB
Referenced Files
None
Subscribers
None
D15409.id37149.diff
View Options
diff --git a/src/applications/badges/storage/PhabricatorBadgesBadge.php b/src/applications/badges/storage/PhabricatorBadgesBadge.php
--- a/src/applications/badges/storage/PhabricatorBadgesBadge.php
+++ b/src/applications/badges/storage/PhabricatorBadgesBadge.php
@@ -181,10 +181,6 @@
return ($this->creatorPHID == $phid);
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenReceiverInterface )---------------------------------- */
diff --git a/src/applications/calendar/storage/PhabricatorCalendarEvent.php b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
--- a/src/applications/calendar/storage/PhabricatorCalendarEvent.php
+++ b/src/applications/calendar/storage/PhabricatorCalendarEvent.php
@@ -531,10 +531,6 @@
return ($phid == $this->getUserPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenReceiverInterface )---------------------------------- */
diff --git a/src/applications/countdown/storage/PhabricatorCountdown.php b/src/applications/countdown/storage/PhabricatorCountdown.php
--- a/src/applications/countdown/storage/PhabricatorCountdown.php
+++ b/src/applications/countdown/storage/PhabricatorCountdown.php
@@ -70,9 +70,6 @@
return ($phid == $this->getAuthorPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
/* -( PhabricatorApplicationTransactionInterface )------------------------- */
diff --git a/src/applications/differential/storage/DifferentialRevision.php b/src/applications/differential/storage/DifferentialRevision.php
--- a/src/applications/differential/storage/DifferentialRevision.php
+++ b/src/applications/differential/storage/DifferentialRevision.php
@@ -485,10 +485,6 @@
return false;
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorCustomFieldInterface )------------------------------------ */
diff --git a/src/applications/files/storage/PhabricatorFile.php b/src/applications/files/storage/PhabricatorFile.php
--- a/src/applications/files/storage/PhabricatorFile.php
+++ b/src/applications/files/storage/PhabricatorFile.php
@@ -1348,10 +1348,6 @@
return ($this->authorPHID == $phid);
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenReceiverInterface )---------------------------------- */
diff --git a/src/applications/fund/storage/FundInitiative.php b/src/applications/fund/storage/FundInitiative.php
--- a/src/applications/fund/storage/FundInitiative.php
+++ b/src/applications/fund/storage/FundInitiative.php
@@ -178,10 +178,6 @@
return ($phid == $this->getOwnerPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenRecevierInterface )---------------------------------- */
diff --git a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php
--- a/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php
+++ b/src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php
@@ -127,10 +127,6 @@
return false;
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorApplicationTransactionInterface )------------------------- */
diff --git a/src/applications/herald/storage/HeraldRule.php b/src/applications/herald/storage/HeraldRule.php
--- a/src/applications/herald/storage/HeraldRule.php
+++ b/src/applications/herald/storage/HeraldRule.php
@@ -328,10 +328,6 @@
return $this->isPersonalRule() && $phid == $this->getAuthorPHID();
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorDestructibleInterface )----------------------------------- */
diff --git a/src/applications/legalpad/storage/LegalpadDocument.php b/src/applications/legalpad/storage/LegalpadDocument.php
--- a/src/applications/legalpad/storage/LegalpadDocument.php
+++ b/src/applications/legalpad/storage/LegalpadDocument.php
@@ -163,10 +163,6 @@
return ($this->creatorPHID == $phid);
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorPolicyInterface )----------------------------------------- */
diff --git a/src/applications/macro/storage/PhabricatorFileImageMacro.php b/src/applications/macro/storage/PhabricatorFileImageMacro.php
--- a/src/applications/macro/storage/PhabricatorFileImageMacro.php
+++ b/src/applications/macro/storage/PhabricatorFileImageMacro.php
@@ -111,10 +111,6 @@
return false;
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenRecevierInterface )---------------------------------- */
diff --git a/src/applications/maniphest/storage/ManiphestTask.php b/src/applications/maniphest/storage/ManiphestTask.php
--- a/src/applications/maniphest/storage/ManiphestTask.php
+++ b/src/applications/maniphest/storage/ManiphestTask.php
@@ -269,10 +269,6 @@
return ($phid == $this->getOwnerPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( Markup Interface )--------------------------------------------------- */
diff --git a/src/applications/passphrase/storage/PassphraseCredential.php b/src/applications/passphrase/storage/PassphraseCredential.php
--- a/src/applications/passphrase/storage/PassphraseCredential.php
+++ b/src/applications/passphrase/storage/PassphraseCredential.php
@@ -157,10 +157,6 @@
return false;
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorDestructibleInterface )----------------------------------- */
diff --git a/src/applications/paste/storage/PhabricatorPaste.php b/src/applications/paste/storage/PhabricatorPaste.php
--- a/src/applications/paste/storage/PhabricatorPaste.php
+++ b/src/applications/paste/storage/PhabricatorPaste.php
@@ -155,10 +155,6 @@
return ($this->authorPHID == $phid);
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenReceiverInterface )---------------------------------- */
diff --git a/src/applications/phame/storage/PhameBlog.php b/src/applications/phame/storage/PhameBlog.php
--- a/src/applications/phame/storage/PhameBlog.php
+++ b/src/applications/phame/storage/PhameBlog.php
@@ -336,10 +336,6 @@
return ($this->creatorPHID == $phid);
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorConduitResultInterface )---------------------------------- */
diff --git a/src/applications/phame/storage/PhamePost.php b/src/applications/phame/storage/PhamePost.php
--- a/src/applications/phame/storage/PhamePost.php
+++ b/src/applications/phame/storage/PhamePost.php
@@ -282,10 +282,6 @@
return ($this->bloggerPHID == $phid);
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorConduitResultInterface )---------------------------------- */
diff --git a/src/applications/pholio/storage/PholioMock.php b/src/applications/pholio/storage/PholioMock.php
--- a/src/applications/pholio/storage/PholioMock.php
+++ b/src/applications/pholio/storage/PholioMock.php
@@ -184,10 +184,6 @@
return ($this->authorPHID == $phid);
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorPolicyInterface Implementation )-------------------------- */
diff --git a/src/applications/phriction/storage/PhrictionDocument.php b/src/applications/phriction/storage/PhrictionDocument.php
--- a/src/applications/phriction/storage/PhrictionDocument.php
+++ b/src/applications/phriction/storage/PhrictionDocument.php
@@ -194,9 +194,6 @@
return false;
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
/* -( PhabricatorApplicationTransactionInterface )------------------------- */
diff --git a/src/applications/phurl/storage/PhabricatorPhurlURL.php b/src/applications/phurl/storage/PhabricatorPhurlURL.php
--- a/src/applications/phurl/storage/PhabricatorPhurlURL.php
+++ b/src/applications/phurl/storage/PhabricatorPhurlURL.php
@@ -169,9 +169,6 @@
return ($phid == $this->getAuthorPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
/* -( PhabricatorTokenReceiverInterface )---------------------------------- */
diff --git a/src/applications/ponder/storage/PonderAnswer.php b/src/applications/ponder/storage/PonderAnswer.php
--- a/src/applications/ponder/storage/PonderAnswer.php
+++ b/src/applications/ponder/storage/PonderAnswer.php
@@ -219,10 +219,6 @@
return ($phid == $this->getAuthorPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorDestructibleInterface )----------------------------------- */
diff --git a/src/applications/ponder/storage/PonderQuestion.php b/src/applications/ponder/storage/PonderQuestion.php
--- a/src/applications/ponder/storage/PonderQuestion.php
+++ b/src/applications/ponder/storage/PonderQuestion.php
@@ -248,10 +248,6 @@
return ($phid == $this->getAuthorPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenReceiverInterface )---------------------------------- */
diff --git a/src/applications/repository/storage/PhabricatorRepositoryCommit.php b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
--- a/src/applications/repository/storage/PhabricatorRepositoryCommit.php
+++ b/src/applications/repository/storage/PhabricatorRepositoryCommit.php
@@ -443,10 +443,6 @@
return ($phid == $this->getAuthorPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorApplicationTransactionInterface )------------------------- */
diff --git a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
--- a/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
+++ b/src/applications/slowvote/storage/PhabricatorSlowvotePoll.php
@@ -179,10 +179,6 @@
return ($phid == $this->getAuthorPHID());
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorTokenReceiverInterface )---------------------------------- */
diff --git a/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php b/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
--- a/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
+++ b/src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php
@@ -96,11 +96,6 @@
return;
}
- if (!$object->shouldShowSubscribersProperty()) {
- // This object doesn't render subscribers in its property list.
- return;
- }
-
$subscribers = PhabricatorSubscribersQuery::loadSubscribersForPHID(
$object->getPHID());
if ($subscribers) {
diff --git a/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php b/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php
--- a/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php
+++ b/src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php
@@ -13,15 +13,6 @@
*/
public function isAutomaticallySubscribed($phid);
-
- /**
- * Return `true` to indicate that "Subscribers:" should be shown when
- * rendering property lists for this object, or `false` to omit the property.
- *
- * @return bool True to show the "Subscribers:" property.
- */
- public function shouldShowSubscribersProperty();
-
}
// TEMPLATE IMPLEMENTATION /////////////////////////////////////////////////////
@@ -33,8 +24,4 @@
return false;
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
*/
diff --git a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
--- a/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
+++ b/src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php
@@ -218,10 +218,6 @@
return false;
}
- public function shouldShowSubscribersProperty() {
- return true;
- }
-
/* -( PhabricatorApplicationTransactionInterface )------------------------- */
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Nov 3, 4:02 AM (2 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6743732
Default Alt Text
D15409.id37149.diff (12 KB)
Attached To
Mode
D15409: Remove shouldShowSubscribersProperty() from SubscribableInterface
Attached
Detach File
Event Timeline
Log In to Comment