Page MenuHomePhabricator
Differential D15409

Remove shouldShowSubscribersProperty() from SubscribableInterface
ClosedPublic
Actions

Authored by epriestley on Mar 5 2016, 11:08 PM.
Tags
None
Referenced Files
F14013296: D15409.id37149.diff
Sat, Nov 2, 4:02 AM
F13992092: D15409.id37155.diff
Tue, Oct 22, 2:18 PM
F13990831: D15409.diff
Tue, Oct 22, 6:37 AM
Unknown Object (File)
Oct 13 2024, 7:44 PM
Unknown Object (File)
Oct 4 2024, 2:56 AM
Unknown Object (File)
Oct 2 2024, 1:43 AM
Unknown Object (File)
Sep 14 2024, 9:15 AM
Unknown Object (File)
Sep 14 2024, 9:13 AM
View All Files
Subscribers
None

Details

Reviewers
chad
Commits
Restricted Diffusion Commit
rPabb4c03b476d: Remove shouldShowSubscribersProperty() from SubscribableInterface
Summary

Every caller returns true. This was added a long time ago for Projects, but projects are no longer subscribable.

I don't anticipate needing this in the future.

Test Plan

Grepped for this method.

Diff Detail

Repository
rP Phabricator
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 37149.Mar 5 2016, 11:08 PM
epriestley retitled this revision from to Remove shouldShowSubscribersProperty() from SubscribableInterface.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: chad.
chad accepted this revision.Mar 5 2016, 11:45 PM
chad edited edge metadata.

bold

This revision is now accepted and ready to land.Mar 5 2016, 11:45 PM
Closed by commit rPabb4c03b476d: Remove shouldShowSubscribersProperty() from SubscribableInterface (authored by epriestley, committed by epriestley). · Explain WhyMar 6 2016, 2:01 PM
This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

PathSize
src/
applications/
badges/
storage/
4 lines
calendar/
storage/
4 lines
countdown/
storage/
3 lines
differential/
storage/
4 lines
files/
storage/
4 lines
fund/
storage/
4 lines
harbormaster/
storage/
configuration/
4 lines
herald/
storage/
4 lines
legalpad/
storage/
4 lines
macro/
storage/
4 lines
maniphest/
storage/
4 lines
passphrase/
storage/
4 lines
paste/
storage/
4 lines
phame/
storage/
4 lines
4 lines
pholio/
storage/
4 lines
phriction/
storage/
3 lines
phurl/
storage/
3 lines
ponder/
storage/
4 lines
4 lines
repository/
storage/
4 lines
slowvote/
storage/
4 lines
subscriptions/
events/
5 lines
interface/
13 lines
infrastructure/
daemon/
workers/
storage/
4 lines

Diff 37155

View Options

src/applications/badges/storage/PhabricatorBadgesBadge.php

Loading...
View Options

src/applications/calendar/storage/PhabricatorCalendarEvent.php

Loading...
View Options

src/applications/countdown/storage/PhabricatorCountdown.php

Loading...
View Options

src/applications/differential/storage/DifferentialRevision.php

Loading...
View Options

src/applications/files/storage/PhabricatorFile.php

Loading...
View Options

src/applications/fund/storage/FundInitiative.php

Loading...
View Options

src/applications/harbormaster/storage/configuration/HarbormasterBuildPlan.php

Loading...
View Options

src/applications/herald/storage/HeraldRule.php

Loading...
View Options

src/applications/legalpad/storage/LegalpadDocument.php

Loading...
View Options

src/applications/macro/storage/PhabricatorFileImageMacro.php

Loading...
View Options

src/applications/maniphest/storage/ManiphestTask.php

Loading...
View Options

src/applications/passphrase/storage/PassphraseCredential.php

Loading...
View Options

src/applications/paste/storage/PhabricatorPaste.php

Loading...
View Options

src/applications/phame/storage/PhameBlog.php

Loading...
View Options

src/applications/phame/storage/PhamePost.php

Loading...
View Options

src/applications/pholio/storage/PholioMock.php

Loading...
View Options

src/applications/phriction/storage/PhrictionDocument.php

Loading...
View Options

src/applications/phurl/storage/PhabricatorPhurlURL.php

Loading...
View Options

src/applications/ponder/storage/PonderAnswer.php

Loading...
View Options

src/applications/ponder/storage/PonderQuestion.php

Loading...
View Options

src/applications/repository/storage/PhabricatorRepositoryCommit.php

Loading...
View Options

src/applications/slowvote/storage/PhabricatorSlowvotePoll.php

Loading...
View Options

src/applications/subscriptions/events/PhabricatorSubscriptionsUIEventListener.php

Loading...
View Options

src/applications/subscriptions/interface/PhabricatorSubscribableInterface.php

Loading...
View Options

src/infrastructure/daemon/workers/storage/PhabricatorWorkerBulkJob.php

Loading...
Phabricator · Built by Phacility