Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14012549
D15027.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D15027.diff
View Options
diff --git a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
--- a/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
+++ b/src/applications/diffusion/engine/DiffusionCommitHookEngine.php
@@ -308,6 +308,7 @@
$rules = null;
$blocking_effect = null;
$blocked_update = null;
+ $blocking_xscript = null;
foreach ($updates as $update) {
$adapter = id(clone $adapter_template)
->setPushLog($update);
@@ -332,6 +333,7 @@
if ($effect->getAction() == $block_action) {
$blocking_effect = $effect;
$blocked_update = $update;
+ $blocking_xscript = $xscript;
break;
}
}
@@ -357,13 +359,16 @@
throw new DiffusionCommitHookRejectException(
pht(
"This push was rejected by Herald push rule %s.\n".
- "Change: %s\n".
- " Rule: %s\n".
- "Reason: %s",
+ " Change: %s\n".
+ " Rule: %s\n".
+ " Reason: %s\n".
+ "Transcript: %s",
$rule->getMonogram(),
$blocked_name,
$rule->getName(),
- $message));
+ $message,
+ PhabricatorEnv::getProductionURI(
+ '/herald/transcript/'.$blocking_xscript->getID().'/')));
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sat, Nov 2, 2:50 PM (2 w, 2 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6721520
Default Alt Text
D15027.diff (1 KB)
Attached To
Mode
D15027: Add link to Herald Transaction when blocking pushes
Attached
Detach File
Event Timeline
Log In to Comment