Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14010408
D10762.id25830.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
8 KB
Referenced Files
None
Subscribers
None
D10762.id25830.diff
View Options
diff --git a/src/applications/audit/editor/PhabricatorAuditEditor.php b/src/applications/audit/editor/PhabricatorAuditEditor.php
--- a/src/applications/audit/editor/PhabricatorAuditEditor.php
+++ b/src/applications/audit/editor/PhabricatorAuditEditor.php
@@ -678,7 +678,7 @@
$monogram = $object->getRepository()->formatCommitName(
$object->getCommitIdentifier());
- $body->addTextSection(
+ $body->addLinkSection(
pht('COMMIT'),
PhabricatorEnv::getProductionURI('/'.$monogram));
diff --git a/src/applications/conpherence/editor/ConpherenceEditor.php b/src/applications/conpherence/editor/ConpherenceEditor.php
--- a/src/applications/conpherence/editor/ConpherenceEditor.php
+++ b/src/applications/conpherence/editor/ConpherenceEditor.php
@@ -405,7 +405,7 @@
array $xactions) {
$body = parent::buildMailBody($object, $xactions);
- $body->addTextSection(
+ $body->addLinkSection(
pht('CONPHERENCE DETAIL'),
PhabricatorEnv::getProductionURI('/conpherence/'.$object->getID().'/'));
diff --git a/src/applications/differential/customfield/DifferentialChangesSinceLastUpdateField.php b/src/applications/differential/customfield/DifferentialChangesSinceLastUpdateField.php
--- a/src/applications/differential/customfield/DifferentialChangesSinceLastUpdateField.php
+++ b/src/applications/differential/customfield/DifferentialChangesSinceLastUpdateField.php
@@ -54,7 +54,7 @@
$uri = '/'.$revision->getMonogram().'?vs='.$old_id.'&id='.$new_id;
$uri = PhabricatorEnv::getProductionURI($uri);
- $body->addTextSection(pht('CHANGES SINCE LAST UPDATE'), $uri);
+ $body->addLinkSection(pht('CHANGES SINCE LAST UPDATE'), $uri);
}
}
diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -1140,7 +1140,7 @@
$changed_uri = $this->getChangedPriorToCommitURI();
if ($changed_uri) {
- $body->addTextSection(
+ $body->addLinkSection(
pht('CHANGED PRIOR TO COMMIT'),
$changed_uri);
}
@@ -1151,7 +1151,7 @@
$this->renderInlineCommentsForMail($object, $inlines));
}
- $body->addTextSection(
+ $body->addLinkSection(
pht('REVISION DETAIL'),
PhabricatorEnv::getProductionURI('/D'.$object->getID()));
diff --git a/src/applications/fund/editor/FundInitiativeEditor.php b/src/applications/fund/editor/FundInitiativeEditor.php
--- a/src/applications/fund/editor/FundInitiativeEditor.php
+++ b/src/applications/fund/editor/FundInitiativeEditor.php
@@ -267,7 +267,7 @@
$body = parent::buildMailBody($object, $xactions);
- $body->addTextSection(
+ $body->addLinkSection(
pht('INITIATIVE DETAIL'),
PhabricatorEnv::getProductionURI('/'.$object->getMonogram()));
diff --git a/src/applications/legalpad/editor/LegalpadDocumentEditor.php b/src/applications/legalpad/editor/LegalpadDocumentEditor.php
--- a/src/applications/legalpad/editor/LegalpadDocumentEditor.php
+++ b/src/applications/legalpad/editor/LegalpadDocumentEditor.php
@@ -194,7 +194,7 @@
$body = parent::buildMailBody($object, $xactions);
- $body->addTextSection(
+ $body->addLinkSection(
pht('DOCUMENT DETAIL'),
PhabricatorEnv::getProductionURI('/legalpad/view/'.$object->getID().'/'));
diff --git a/src/applications/macro/editor/PhabricatorMacroEditor.php b/src/applications/macro/editor/PhabricatorMacroEditor.php
--- a/src/applications/macro/editor/PhabricatorMacroEditor.php
+++ b/src/applications/macro/editor/PhabricatorMacroEditor.php
@@ -173,7 +173,7 @@
array $xactions) {
$body = parent::buildMailBody($object, $xactions);
- $body->addTextSection(
+ $body->addLinkSection(
pht('MACRO DETAIL'),
PhabricatorEnv::getProductionURI('/macro/view/'.$object->getID().'/'));
diff --git a/src/applications/maniphest/editor/ManiphestTransactionEditor.php b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
--- a/src/applications/maniphest/editor/ManiphestTransactionEditor.php
+++ b/src/applications/maniphest/editor/ManiphestTransactionEditor.php
@@ -497,7 +497,7 @@
$object->getDescription());
}
- $body->addTextSection(
+ $body->addLinkSection(
pht('TASK DETAIL'),
PhabricatorEnv::getProductionURI('/T'.$object->getID()));
diff --git a/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php b/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
--- a/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
+++ b/src/applications/metamta/view/PhabricatorMetaMTAMailBody.php
@@ -82,7 +82,13 @@
phutil_tag('div', array('style' => 'font-weight:800;'), $header),
$html_fragment,
);
+ return $this;
+ }
+ public function addLinkSection($header, $link) {
+ $html = phutil_tag('a', array('href' => $link), $link);
+ $this->addPlaintextSection($header, $link);
+ $this->addHTMLSection($header, $html);
return $this;
}
diff --git a/src/applications/metamta/view/PhabricatorMetaMTAMailSection.php b/src/applications/metamta/view/PhabricatorMetaMTAMailSection.php
--- a/src/applications/metamta/view/PhabricatorMetaMTAMailSection.php
+++ b/src/applications/metamta/view/PhabricatorMetaMTAMailSection.php
@@ -22,7 +22,6 @@
public function addHTMLFragment($fragment) {
$this->htmlFragments[] = $fragment;
return $this;
-
}
public function addPlaintextFragment($fragment) {
diff --git a/src/applications/paste/editor/PhabricatorPasteEditor.php b/src/applications/paste/editor/PhabricatorPasteEditor.php
--- a/src/applications/paste/editor/PhabricatorPasteEditor.php
+++ b/src/applications/paste/editor/PhabricatorPasteEditor.php
@@ -167,7 +167,7 @@
$body = parent::buildMailBody($object, $xactions);
- $body->addTextSection(
+ $body->addLinkSection(
pht('PASTE DETAIL'),
PhabricatorEnv::getProductionURI('/P'.$object->getID()));
diff --git a/src/applications/pholio/editor/PholioMockEditor.php b/src/applications/pholio/editor/PholioMockEditor.php
--- a/src/applications/pholio/editor/PholioMockEditor.php
+++ b/src/applications/pholio/editor/PholioMockEditor.php
@@ -409,7 +409,7 @@
}
}
- $body->addTextSection(
+ $body->addLinkSection(
pht('MOCK DETAIL'),
PhabricatorEnv::getProductionURI('/M'.$object->getID()));
diff --git a/src/applications/phortune/editor/PhortuneCartEditor.php b/src/applications/phortune/editor/PhortuneCartEditor.php
--- a/src/applications/phortune/editor/PhortuneCartEditor.php
+++ b/src/applications/phortune/editor/PhortuneCartEditor.php
@@ -123,7 +123,7 @@
$body->addTextSection(pht('ORDER CONTENTS'), implode("\n", $items));
- $body->addTextSection(
+ $body->addLinkSection(
pht('ORDER DETAIL'),
PhabricatorEnv::getProductionURI('/phortune/cart/'.$object->getID().'/'));
diff --git a/src/applications/phriction/editor/PhrictionTransactionEditor.php b/src/applications/phriction/editor/PhrictionTransactionEditor.php
--- a/src/applications/phriction/editor/PhrictionTransactionEditor.php
+++ b/src/applications/phriction/editor/PhrictionTransactionEditor.php
@@ -242,7 +242,7 @@
$object->getContent()->getContent());
}
- $body->addTextSection(
+ $body->addLinkSection(
pht('DOCUMENT DETAIL'),
PhabricatorEnv::getProductionURI(
PhrictionDocument::getSlugURI($object->getSlug())));
diff --git a/src/applications/ponder/editor/PonderAnswerEditor.php b/src/applications/ponder/editor/PonderAnswerEditor.php
--- a/src/applications/ponder/editor/PonderAnswerEditor.php
+++ b/src/applications/ponder/editor/PonderAnswerEditor.php
@@ -98,7 +98,7 @@
}
}
- $body->addTextSection(
+ $body->addLinkSection(
pht('ANSWER DETAIL'),
PhabricatorEnv::getProductionURI($object->getURI()));
diff --git a/src/applications/ponder/editor/PonderQuestionEditor.php b/src/applications/ponder/editor/PonderQuestionEditor.php
--- a/src/applications/ponder/editor/PonderQuestionEditor.php
+++ b/src/applications/ponder/editor/PonderQuestionEditor.php
@@ -243,7 +243,7 @@
}
}
- $body->addTextSection(
+ $body->addLinkSection(
$header,
PhabricatorEnv::getProductionURI($uri));
diff --git a/src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php b/src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php
--- a/src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php
+++ b/src/applications/repository/worker/PhabricatorRepositoryPushMailWorker.php
@@ -70,7 +70,7 @@
$body = new PhabricatorMetaMTAMailBody();
$body->addRawSection($overview);
- $body->addTextSection(pht('DETAILS'), $details_uri);
+ $body->addLinkSection(pht('DETAILS'), $details_uri);
if ($commit_lines) {
$body->addTextSection(pht('COMMITS'), implode("\n", $commit_lines));
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Nov 1, 7:27 AM (2 w, 3 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6755961
Default Alt Text
D10762.id25830.diff (8 KB)
Attached To
Mode
D10762: Add addLinkSection to MailBody to properly format URIs
Attached
Detach File
Event Timeline
Log In to Comment