D10467.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D10467.diff
View Options

	diff --git a/src/lint/linter/ArcanistXHPASTLinter.php b/src/lint/linter/ArcanistXHPASTLinter.php
	--- a/src/lint/linter/ArcanistXHPASTLinter.php
	+++ b/src/lint/linter/ArcanistXHPASTLinter.php
	@@ -384,9 +384,15 @@
	continue;
	}

	- $function_name = $function
	- ->getChildOfType(0, 'n_SYMBOL_NAME')
	- ->getConcreteString();
	+ $function_token = $function
	+ ->getChildByIndex(0);
	+
	+ if ($function_token->getTypeName() != 'n_SYMBOL_NAME') {
	+ // This may be `Class::method(...)` or `$var(...)`.
	+ continue;
	+ }
	+
	+ $function_name = $function_token->getConcreteString();

	switch ($function_name) {
	case 'class_exists':
	diff --git a/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test b/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test
	--- a/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test
	+++ b/src/lint/linter/__tests__/xhpast/conditional-usage.lint-test
	@@ -11,6 +11,11 @@
	new CURLFile('');
	new DateTimeImmutable();
	}
	+
	+// These shouldn't fatal.
	+if (SomeClass::someStaticMethod($param)) {}
	+$var = 'some_func';
	+if ($var()) {}
	~~~~~~~~~~
	error:5:3
	error:7:3