Fix PHP version check for function calls with static/variable functions
ClosedPublic
Actions

Authored by epriestley on Sep 10 2014, 8:19 PM.

Details

Reviewers

joshuaspence
btrahan

Commits

rARCe043d22afd26: Fix PHP version check for function calls with static/variable functions

Summary

D10132 improved this check by eliminating some false postives, but assumes an n_FUNCTION_CALL always starts with n_SYMBOL_NAME. This is true for f(), but not true for C::m() or $v().

Test Plan

Added and ran unit tests.

Diff Detail

Repository

rARC Arcanist

Lint

Lint Skipped

Unit

Tests Skipped

Event Timeline

epriestley updated this revision to Diff 25170.Sep 10 2014, 8:19 PM

epriestley retitled this revision from to Fix PHP version check for function calls with static/variable functions.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: btrahan, joshuaspence.

Herald added a subscriber: epriestley. · View Herald TranscriptSep 10 2014, 8:19 PM

Harbormaster completed remote builds in B2496: Diff 25170.Sep 10 2014, 8:19 PM

joshuaspence accepted this revision.Sep 10 2014, 8:53 PM

joshuaspence edited edge metadata.

This revision is now accepted and ready to land.Sep 10 2014, 8:53 PM

Closed by commit rARCe043d22afd26 (authored by @epriestley).

Revision Contents
Changeset List

Path

Size

src/

lint/

linter/

ArcanistXHPASTLinter.php

12 lines

__tests__/

xhpast/

conditional-usage.lint-test

5 lines

Diff 25171

View Options

src/lint/linter/ArcanistXHPASTLinter.php

View Options

src/lint/linter/tests/xhpast/conditional-usage.lint-test

Fix PHP version check for function calls with static/variable functionsClosedPublicActions