Page MenuHomePhabricator

Fix PHP version check for function calls with static/variable functions
ClosedPublic

Authored by epriestley on Sep 10 2014, 8:19 PM.
Tags
None
Referenced Files
F14008379: D10467.diff
Tue, Oct 29, 8:17 PM
F13976516: D10467.id25170.diff
Fri, Oct 18, 2:37 PM
F13969224: D10467.id25171.diff
Thu, Oct 17, 1:17 AM
F13964011: D10467.id25171.diff
Tue, Oct 15, 7:14 PM
Unknown Object (File)
Sep 30 2024, 4:10 AM
Unknown Object (File)
Sep 18 2024, 3:34 PM
Unknown Object (File)
Sep 12 2024, 3:16 PM
Unknown Object (File)
Sep 12 2024, 3:15 PM
Subscribers

Details

Summary

D10132 improved this check by eliminating some false postives, but assumes an n_FUNCTION_CALL always starts with n_SYMBOL_NAME. This is true for f(), but not true for C::m() or $v().

Test Plan

Added and ran unit tests.

Diff Detail

Repository
rARC Arcanist
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Fix PHP version check for function calls with static/variable functions.
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added reviewers: btrahan, joshuaspence.
This revision is now accepted and ready to land.Sep 10 2014, 8:53 PM
epriestley updated this revision to Diff 25171.

Closed by commit rARCe043d22afd26 (authored by @epriestley).