Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F14004205
D8533.id20242.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
932 B
Referenced Files
None
Subscribers
None
D8533.id20242.diff
View Options
diff --git a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
--- a/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
+++ b/src/applications/transactions/view/PhabricatorApplicationTransactionView.php
@@ -193,14 +193,18 @@
$engine = $this->getOrBuildEngine();
$comment = $xaction->getComment();
- if ($xaction->hasComment()) {
+ if ($comment) {
if ($comment->getIsDeleted()) {
return phutil_tag(
'em',
array(),
pht('This comment has been deleted.'));
- } else {
+ } else if ($xaction->hasComment()) {
return $engine->getOutput($comment, $field);
+ } else {
+ // This is an empty, non-deleted comment. Usually this happens when
+ // rendering previews.
+ return null;
}
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Sun, Oct 27, 5:07 PM (3 w, 1 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6752435
Default Alt Text
D8533.id20242.diff (932 B)
Attached To
Mode
D8533: Fix rendering of comments deleted by editing
Attached
Detach File
Event Timeline
Log In to Comment