D16685.id.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D16685.id.diff
View Options

	diff --git a/src/applications/config/view/PhabricatorSetupIssueView.php b/src/applications/config/view/PhabricatorSetupIssueView.php
	--- a/src/applications/config/view/PhabricatorSetupIssueView.php
	+++ b/src/applications/config/view/PhabricatorSetupIssueView.php
	@@ -404,19 +404,48 @@
	implode("\n", $more_loc));
	}

	- $info[] = phutil_tag(
	- 'p',
	- array(),
	- pht(
	- 'You can find more information about PHP configuration values in the '.
	- '%s.',
	- phutil_tag(
	- 'a',
	- array(
	- 'href' => 'http://php.net/manual/ini.list.php',
	- 'target' => '_blank',
	- ),
	- pht('PHP Documentation'))));
	+ $show_standard = false;
	+ $show_opcache = false;
	+
	+ foreach ($configs as $key) {
	+ if (preg_match('/^opcache\./', $key)) {
	+ $show_opcache = true;
	+ } else {
	+ $show_standard = true;
	+ }
	+ }
	+
	+ if ($show_standard) {
	+ $info[] = phutil_tag(
	+ 'p',
	+ array(),
	+ pht(
	+ 'You can find more information about PHP configuration values '.
	+ 'in the %s.',
	+ phutil_tag(
	+ 'a',
	+ array(
	+ 'href' => 'http://php.net/manual/ini.list.php',
	+ 'target' => '_blank',
	+ ),
	+ pht('PHP Documentation'))));
	+ }
	+
	+ if ($show_opcache) {
	+ $info[] = phutil_tag(
	+ 'p',
	+ array(),
	+ pht(
	+ 'You can find more information about configuring OPCache in '.
	+ 'the %s.',
	+ phutil_tag(
	+ 'a',
	+ array(
	+ 'href' => 'http://php.net/manual/opcache.configuration.php',
	+ 'target' => '_blank',
	+ ),
	+ pht('PHP OPCache Documentation'))));
	+ }

	$info[] = phutil_tag(
	'p',