Differential D16685

When setup issues raise opcache configuration errors, point at the opcache configuration page
ClosedPublic
Actions

Authored by epriestley on Oct 7 2016, 3:10 PM.

Details

Reviewers

chad

Maniphest Tasks

T11746: Link for setup issue: opcache.validate_timestamps is incorrect

Commits

rPce14338081e1: When setup issues raise opcache configuration errors, point at the opcache…

Summary

Fixes T11746. The opcache docs are on a different page, so point there if we're raising opcache issues.

(It's possible for a setup issue to say "configure X, or configure Y", where X is opcache and Y is non-opcache, so we may want to render both links.)

Test Plan

Screen Shot 2016-10-07 at 8.07.01 AM.png (1×1 px, 227 KB)

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 40170.Oct 7 2016, 3:10 PM

epriestley retitled this revision from to When setup issues raise opcache configuration errors, point at the opcache configuration page.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added a reviewer: chad.

epriestley added a task: T11746: Link for setup issue: opcache.validate_timestamps is incorrect.

chad accepted this revision.Oct 7 2016, 3:11 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Oct 7 2016, 3:11 PM

Closed by commit rPce14338081e1: When setup issues raise opcache configuration errors, point at the opcache… (authored by epriestley, committed by epriestley). · Explain WhyOct 7 2016, 3:23 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

config/

view/

PhabricatorSetupIssueView.php

55 lines

Diff 40171

View Options

src/applications/config/view/PhabricatorSetupIssueView.php

When setup issues raise opcache configuration errors, point at the opcache configuration pageClosedPublicActions