Page MenuHomePhabricator

D7709.diff
No OneTemporary

D7709.diff

Index: src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
===================================================================
--- src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
+++ src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
@@ -53,6 +53,12 @@
$xobj = $ref
->newExternalObject()
->setImporterPHID($viewer->getPHID());
+
+ // NOTE: Fill the new external object into the object map, so we'll
+ // reference the same external object if more than one ref is the
+ // same. This prevents issues later where we double-populate
+ // external objects when handed duplicate refs.
+ $xobjs[$ref->getObjectKey()] = $xobj;
}
$ref->attachExternalObject($xobj);
}

File Metadata

Mime Type
text/plain
Expires
Fri, Oct 25, 2:38 PM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6748806
Default Alt Text
D7709.diff (801 B)

Event Timeline