Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13999420
D7709.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
801 B
Referenced Files
None
Subscribers
None
D7709.diff
View Options
Index: src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
===================================================================
--- src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
+++ src/applications/doorkeeper/engine/DoorkeeperImportEngine.php
@@ -53,6 +53,12 @@
$xobj = $ref
->newExternalObject()
->setImporterPHID($viewer->getPHID());
+
+ // NOTE: Fill the new external object into the object map, so we'll
+ // reference the same external object if more than one ref is the
+ // same. This prevents issues later where we double-populate
+ // external objects when handed duplicate refs.
+ $xobjs[$ref->getObjectKey()] = $xobj;
}
$ref->attachExternalObject($xobj);
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Fri, Oct 25, 2:38 PM (2 w, 4 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6748806
Default Alt Text
D7709.diff (801 B)
Attached To
Mode
D7709: Fix an edge case when trying to pull duplicate refs via Doorkeeper
Attached
Detach File
Event Timeline
Log In to Comment