Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13994649
D8542.id20267.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
985 B
Referenced Files
None
Subscribers
None
D8542.id20267.diff
View Options
diff --git a/src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php b/src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php
--- a/src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php
+++ b/src/infrastructure/markup/rule/PhabricatorRemarkupRuleObject.php
@@ -42,17 +42,10 @@
protected function renderObjectRef($object, $handle, $anchor, $id) {
$href = $handle->getURI();
$text = $this->getObjectNamePrefix().$id;
+
if ($anchor) {
- $matches = null;
- if (preg_match('@^(?:comment-)?(\d{1,7})$@', $anchor, $matches)) {
- // Maximum length is 7 because 12345678 could be a file hash in
- // Differential.
- $href = $href.'#comment-'.$matches[1];
- $text = $text.'#'.$matches[1];
- } else {
- $href = $href.'#'.$anchor;
- $text = $text.'#'.$anchor;
- }
+ $href = $href.'#'.$anchor;
+ $text = $text.'#'.$anchor;
}
if ($this->getEngine()->isTextMode()) {
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Thu, Oct 24, 7:32 AM (2 w, 5 d ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6712588
Default Alt Text
D8542.id20267.diff (985 B)
Attached To
Mode
D8542: Always link to "#5" (not "#comment-5") for "T123#5"
Attached
Detach File
Event Timeline
Log In to Comment