Page MenuHomePhabricator

Always link to "#5" (not "#comment-5") for "T123#5"
ClosedPublic

Authored by epriestley on Mar 14 2014, 9:39 PM.
Tags
None
Referenced Files
F19802035: D8542.id.diff
Mar 1 2026, 12:35 PM
F19800713: D8542.id20267.diff
Feb 28 2026, 5:36 PM
F19800711: D8542.id20267.diff
Feb 28 2026, 5:36 PM
F19754865: D8542.id.diff
Feb 17 2026, 11:14 AM
F19525946: D8542.id.diff
Jan 18 2026, 1:04 PM
F19524924: D8542.diff
Jan 18 2026, 5:04 AM
F19503147: D8542.id20267.diff
Jan 8 2026, 9:40 PM
F19303171: D8542.diff
Dec 23 2025, 7:35 PM
Subscribers

Details

Summary

Fixes T3976. Long ago, some applications used "#comment-5" instead of "#5" for transaction/comment anchors. Now everything (I think?) uses "#5"; this is the style used by ApplicationTransactions.

This might break some very old, explcit T123#comment-5 links, or off-site links to the comment-N anchors, but all that stuff generally got renumbered when we migrated anyway and getting you to the right object is like 95% of the job.

Test Plan

Verified that T123#5 now links to #5.

Diff Detail

Repository
rP Phabricator
Lint
Lint Skipped
Unit
Tests Skipped

Event Timeline

epriestley retitled this revision from to Always link to "#5" (not "#comment-5") for "T123#5".
epriestley updated this object.
epriestley edited the test plan for this revision. (Show Details)
epriestley added a reviewer: btrahan.
btrahan edited edge metadata.
This revision is now accepted and ready to land.Mar 14 2014, 9:43 PM
epriestley updated this revision to Diff 20269.

Closed by commit rP3bea0958dd31 (authored by @epriestley).