D16230.diff
No OneTemporary
Actions

Size

1 KB

Referenced Files

None

Subscribers

None

D16230.diff
View Options

	diff --git a/src/applications/base/PhabricatorApplication.php b/src/applications/base/PhabricatorApplication.php
	--- a/src/applications/base/PhabricatorApplication.php
	+++ b/src/applications/base/PhabricatorApplication.php
	@@ -183,7 +183,8 @@
	$item = id(new PHUIListItemView())
	->setName($article['name'])
	->setIcon('fa-book')
	- ->setHref($article['href']);
	+ ->setHref($article['href'])
	+ ->setOpenInNewWindow(true);

	$items[] = $item;
	}
	@@ -203,7 +204,8 @@
	$item = id(new PHUIListItemView())
	->setName($spec['name'])
	->setIcon('fa-envelope-o')
	- ->setHref($href);
	+ ->setHref($href)
	+ ->setOpenInNewWindow(true);
	$items[] = $item;
	}
	}
	diff --git a/src/view/phui/PHUIListItemView.php b/src/view/phui/PHUIListItemView.php
	--- a/src/view/phui/PHUIListItemView.php
	+++ b/src/view/phui/PHUIListItemView.php
	@@ -29,8 +29,18 @@
	private $indented;
	private $hideInApplicationMenu;
	private $icons = array();
	+ private $openInNewWindow = false;

	- public function setHideInApplicationMenu($hide) {
	+ public function setOpenInNewWindow($open_in_new_window) {
	+ $this->openInNewWindow = $open_in_new_window;
	+ return $this;
	+ }
	+
	+ public function getOpenInNewWindow() {
	+ return $this->openInNewWindow;
	+ }
	+
	+ public function setHideInApplicationMenu($hide) {
	$this->hideInApplicationMenu = $hide;
	return $this;
	}
	@@ -294,6 +304,7 @@
	'class' => implode(' ', $classes),
	'meta' => $meta,
	'sigil' => $sigil,
	+ 'target' => $this->getOpenInNewWindow() ? '_blank' : null,
	),
	array(
	$aural,