Open "Help" menu links in a new window
ClosedPublic
Actions

Authored by epriestley on Jul 4 2016, 5:40 PM.

Details

Reviewers

avivey
chad

Maniphest Tasks

T11243: User Guide links should open in a new tab

Commits

rPc7e7f113fd97: Open "Help" menu links in a new window

Summary

Fixes T11243. Seems reasonable to open this stuff in a new window so you don't put any application state in Herald, etc., at risk -- looking in this menu for help with a currently-executing workflow is reasonable and normal.

Test Plan

Clicked a help menu link, saw it open in a new page.

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley updated this revision to Diff 39040.Jul 4 2016, 5:40 PM

epriestley retitled this revision from to Open "Help" menu links in a new window.

epriestley updated this object.

epriestley edited the test plan for this revision. (Show Details)

epriestley added reviewers: chad, avivey.

epriestley added a task: T11243: User Guide links should open in a new tab.

chad accepted this revision.Jul 4 2016, 5:45 PM

chad edited edge metadata.

This revision is now accepted and ready to land.Jul 4 2016, 5:45 PM

Closed by commit rPc7e7f113fd97: Open "Help" menu links in a new window (authored by epriestley, committed by epriestley). · Explain WhyJul 4 2016, 5:59 PM

This revision was automatically updated to reflect the committed changes.

avivey awarded a token.Jul 4 2016, 9:31 PM

chad awarded a token.Jul 4 2016, 9:49 PM

Revision Contents
Changeset List

Path

Size

src/

applications/

base/

PhabricatorApplication.php

6 lines

view/

phui/

PHUIListItemView.php

13 lines

Diff 39041

View Options

src/applications/base/PhabricatorApplication.php