Page Menu
Home
Phabricator
Search
Configure Global Search
Log In
Files
F13990145
D17822.id42851.diff
No One
Temporary
Actions
View File
Edit File
Delete File
View Transforms
Subscribe
Mute Notifications
Award Token
Flag For Later
Size
1 KB
Referenced Files
None
Subscribers
None
D17822.id42851.diff
View Options
diff --git a/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php b/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
--- a/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
+++ b/src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php
@@ -14,7 +14,6 @@
public function getTransactionTypes() {
$types = parent::getTransactionTypes();
- $types[] = PhabricatorTransactions::TYPE_COMMENT;
$types[] = PhabricatorTransactions::TYPE_VIEW_POLICY;
$types[] = PhabricatorSlowvoteTransaction::TYPE_QUESTION;
diff --git a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
--- a/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
+++ b/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php
@@ -298,6 +298,18 @@
}
}
+ if ($template) {
+ try {
+ $comment = $template->getApplicationTransactionCommentObject();
+ } catch (PhutilMethodNotImplementedException $ex) {
+ $comment = null;
+ }
+
+ if ($comment) {
+ $types[] = PhabricatorTransactions::TYPE_COMMENT;
+ }
+ }
+
return $types;
}
File Metadata
Details
Attached
Mime Type
text/plain
Expires
Wed, Oct 23, 1:35 AM (3 w, 1 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6743308
Default Alt Text
D17822.id42851.diff (1 KB)
Attached To
Mode
D17822: Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is supported or not
Attached
Detach File
Event Timeline
Log In to Comment