Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is supported or not
ClosedPublic
Actions

Authored by epriestley on May 3 2017, 5:43 PM.

Tags

None

Referenced Files

	F15491997: D17822.id42851.diff
	Sat, Apr 12, 9:40 AM

	F15488539: D17822.id42857.diff
	Thu, Apr 10, 11:25 PM

	F15478906: D17822.id.diff
	Tue, Apr 8, 3:46 AM

	F15476291: D17822.diff
	Mon, Apr 7, 5:07 AM

	F15412681: D17822.id42857.diff
	Wed, Mar 19, 2:20 PM

	F15407983: D17822.id.diff
	Tue, Mar 18, 8:37 PM

	F15292045: D17822.id42851.diff
	Mar 5 2025, 1:36 AM

	Unknown Object (File)
	Feb 18 2025, 12:19 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rP60a19e36463b: Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is…

Summary

See D17812, etc. We can figure this out by looking at the object carefully. We don't need to go delete all the old TYPE_COMMENT (it doesn't hurt anything) but can nuke it when we see it.

Test Plan

Made a comment in Slowvote (supports commenting).
Viewed an Almanac device (does not support commenting).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 3 2017, 5:43 PM

Harbormaster completed remote builds in B16777: Diff 42851.May 3 2017, 5:44 PM

chad accepted this revision.May 3 2017, 5:48 PM

This revision is now accepted and ready to land.May 3 2017, 5:48 PM

Macro diff assumes this will land

Closed by commit rP60a19e36463b: Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is… (authored by epriestley, committed by epriestley). · Explain WhyMay 3 2017, 6:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

slowvote/

editor/

PhabricatorSlowvoteEditor.php

1 line

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

12 lines

Diff 42857

View Options

src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php