Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is supported or not
ClosedPublic
Actions

Authored by epriestley on May 3 2017, 5:43 PM.

Tags

None

Referenced Files

	F19077784: D17822.id42851.diff
	Dec 1 2025, 4:13 PM

	F19064868: D17822.id42857.diff
	Nov 30 2025, 12:09 AM

	F19037449: D17822.diff
	Nov 25 2025, 11:34 PM

	F19010532: D17822.diff
	Nov 22 2025, 4:49 AM

	F18918778: D17822.id.diff
	Nov 9 2025, 11:12 AM

	F18807907: D17822.id.diff
	Oct 19 2025, 3:46 AM

	F18803928: D17822.diff
	Oct 18 2025, 4:54 AM

	F18771959: D17822.id42851.diff
	Oct 8 2025, 11:14 PM

View All Files

Subscribers

None

Details

Reviewers

chad

Commits

rP60a19e36463b: Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is…

Summary

See D17812, etc. We can figure this out by looking at the object carefully. We don't need to go delete all the old TYPE_COMMENT (it doesn't hurt anything) but can nuke it when we see it.

Test Plan

Made a comment in Slowvote (supports commenting).
Viewed an Almanac device (does not support commenting).

Diff Detail

Repository

rP Phabricator

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

epriestley created this revision.May 3 2017, 5:43 PM

Harbormaster completed remote builds in B16777: Diff 42851.May 3 2017, 5:44 PM

chad accepted this revision.May 3 2017, 5:48 PM

This revision is now accepted and ready to land.May 3 2017, 5:48 PM

Macro diff assumes this will land

Closed by commit rP60a19e36463b: Allow ApplicationTransactionEditor to figure out whether TYPE_COMMENT is… (authored by epriestley, committed by epriestley). · Explain WhyMay 3 2017, 6:21 PM

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

applications/

slowvote/

editor/

PhabricatorSlowvoteEditor.php

1 line

transactions/

editor/

PhabricatorApplicationTransactionEditor.php

12 lines

Diff 42857

View Options

src/applications/slowvote/editor/PhabricatorSlowvoteEditor.php