Page MenuHomePhabricator
Files F13989063

D15863.diff
No OneTemporary
Actions

D15863.diff
View Options

diff --git a/src/applications/differential/editor/DifferentialTransactionEditor.php b/src/applications/differential/editor/DifferentialTransactionEditor.php
--- a/src/applications/differential/editor/DifferentialTransactionEditor.php
+++ b/src/applications/differential/editor/DifferentialTransactionEditor.php
@@ -1385,7 +1385,17 @@
$header = pht('INLINE COMMENTS');
$section_text = "\n".$section->getPlaintext();
- $section_html = $section->getHTML();
+
+ $style = array(
+ 'margin: 12px 0;',
+ );
+
+ $section_html = phutil_tag(
+ 'div',
+ array(
+ 'style' => implode(' ', $style),
+ ),
+ $section->getHTML());
$body->addPlaintextSection($header, $section_text, false);
$body->addHTMLSection($header, $section_html);
diff --git a/src/applications/differential/mail/DifferentialInlineCommentMailView.php b/src/applications/differential/mail/DifferentialInlineCommentMailView.php
--- a/src/applications/differential/mail/DifferentialInlineCommentMailView.php
+++ b/src/applications/differential/mail/DifferentialInlineCommentMailView.php
@@ -201,7 +201,8 @@
if ($is_html) {
$style = array(
- 'padding: 8px 12px;',
+ 'margin: 8px 0;',
+ 'padding: 0 12px;',
);
if ($is_quote) {
@@ -249,7 +250,7 @@
}
$attributes = array(
- 'style' => 'padding: 0; margin: 0;',
+ 'style' => 'padding: 0; margin: 8px;',
);
$engine = PhabricatorMarkupEngine::newMarkupEngine(array())
@@ -461,6 +462,7 @@
if ($link_href) {
$link_style = array(
'float: right;',
+ 'text-decoration: none;',
);
$link = phutil_tag(
@@ -477,7 +479,7 @@
$style = array(
'color: #74777d;',
'background: #eff2f4;',
- 'padding: 4px 8px;',
+ 'padding: 6px 8px;',
'overflow: hidden;',
);

File Metadata

Mime Type
text/plain
Expires
Tue, Oct 22, 5:52 PM (4 w, 2 h ago)
Storage Engine
blob
Storage Format
Encrypted (AES-256-CBC)
Storage Handle
6724534
Default Alt Text
D15863.diff (1 KB)

Event Timeline

Phabricator · Built by Phacility