Ref T10694.
- Shift margins/padding around so inlines with multiple paragraphs get reasonable spacing.
- Add text-decoration: none to the "View Inline" link to kill the underline.
Differential D15863
Minor tweaks to pre/inline style for inline comments in HTML mail epriestley on May 6 2016, 5:54 PM. Authored by Tags None Referenced Files
Subscribers None
Details Ref T10694.
Diff Detail
Event TimelineComment Actions can we also add a little space between INLINE COMMENTS and the box? they're very snuggly
Comment Actions What client is that?
Comment Actions This is what I seen Mail.app, which looks better: The initial line of context with no actual content is a little weird, we can probably just drop that. Of course, it's also possible to leave an inline on a completely blank line, so sometimes it's just going to look a bit weird. It might also be nice to shove all the text to the left (e.g., if every line is indented at least 8 spaces, un-indent every line by 8 spaces), although I think this isn't completely trivial in all cases since sometimes that "whitespace" is really "syntax highlighted whitespace" with tags around it. Comment Actions You can pay for Litmus if you want, btw. I'll get the CEO to sign off on the expense, just make sure to file all the proper forms and accounting should have it turned around in 5-7 days. Comment Actions I tried Litmus but it wasn't immediately obvious that it was super useful -- the resolution on Outlook, at least, wasn't good enough for me to make out some of the details like this. Let me see if it reproduces the Airmail 2 issue, though, at least. Comment Actions I think we should move to NET90 reimbursement, accounting is getting killed on the paper pushers buying all these pencils that they "need". Comment Actions Well, Litmus does not appear to support Airmail. Let me see if I can guess my way through what's going on and we can pursue a more time-consuming approach if that fails. Comment Actions
I wrote this but it looked really, really weird to me: Maybe ok with a rule like "if every line is indented by more than 4 spaces, bring the shallowest indent down to 4 spaces", but I'm just going to drop it for now For posterity: // If the entire remaining block is indented by some amount, push it left. // For instance, if every line is indented by at least 8 spaces, remove the // first 8 spaces from every line. This makes it easier to read snippets // on narrow displays like phones. $common = null; foreach ($out as $key => $line) { $text = $line['text']; $length = strlen(rtrim($text)); // If this line only has whitespace, ignore it. if (!$length) { continue; } $leading = 0; for ($ii = 0; $ii < $length; $ii++) { if ($text[$ii] == ' ') { $leading++; } else { break; } } if ($common === null) { $common = $leading; } else { $common = min($common, $leading); } } // If we have some common leading whitespace, strip it off every snippet // line. if ($common) { foreach ($out as $key => $line) { $render = (string)$line['render']; $render = substr($render, $common); $render = phutil_safe_html($render); $out[$key]['render'] = $render; } } |